1578 nakamoto remove anchor mode #1654

janniks · 2024-03-11T15:05:56Z

This PR was published to npm with the version 6.13.0
e.g. npm install @stacks/[email protected] --save-exact

remove anchor mode from builder methods, default to .Any -- this byte will be ignored by nodes in >= Nakamoto

vercel · 2024-03-11T15:06:03Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
stacksjs-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 10, 2024 3:29pm

codecov · 2024-03-11T15:17:59Z

Codecov Report

Attention: Patch coverage is 75.51020% with 36 lines in your changes missing coverage. Please review.

Project coverage is 66.44%. Comparing base (922e037) to head (17dee7b).
Report is 60 commits behind head on next.

❗ Current head 17dee7b differs from pull request most recent head ca3756a

Please upload reports for the commit ca3756a to get more accurate results.

Files	Patch %	Lines
packages/stacking/src/index.ts	48.83%	17 Missing and 5 partials ⚠️
packages/common/src/buffer.ts	41.66%	7 Missing ⚠️
packages/stacking/src/utils.ts	86.66%	3 Missing and 1 partial ⚠️
packages/transactions/src/payload.ts	94.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #1654      +/-   ##
==========================================
+ Coverage   66.37%   66.44%   +0.06%     
==========================================
  Files         119      119              
  Lines        8717     8800      +83     
  Branches     1920     1958      +38     
==========================================
+ Hits         5786     5847      +61     
+ Misses       2806     2709      -97     
- Partials      125      244     +119

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MicaiahReid

There's one small suggestion, but looks good to me!

packages/stacking/src/utils.ts

janniks · 2024-05-13T13:42:54Z

1578 nakamoto remove anchor mode #1654 👈
fix!: Disable legacy triplesec support for mnemonic encryption #1685
Fix typedoc build #1684
Refactor circular deps #1683
Remove legacy cli methods #1682
feat!: Make serialize methods return hex-encoded strings, instead of bytes #1657
fix: update cli #1656
next

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @janniks and the rest of your teammates on Graphite

* fix!: consolidate poxaddress return types BREAKING CHANGE: Convert `version` of PoXAddress from array to number. * feat: cleanup common files * refactor: update to correct import path * feat!: update to new network object (#1623) * feat: split network into object and api opts * fix: update imports --------- Co-authored-by: janniks <[email protected]> * feat: add new api package * fix: update remaining packages for api (#1625) Co-authored-by: janniks <[email protected]> * refactor: update other packages to new paradigm * test: fix remaining packages * chore: add jest config * chore: resolve circular dependency * build: update commitlint to allow longer content * refactor!: change clarity types to be human readable BREAKING CHANGE: The `ClarityType` was changed to a readable string, from the previous Number type. This makes it easier to read and construct types when debugging. * test: add clarity wire format tests * docs: add migration docs * docs: pr update Co-authored-by: Hugo C <[email protected]> * docs: pr update Co-authored-by: Hugo C <[email protected]> * docs: enumerate nets * feat!: remove wrapped private key type BREAKING CHANGE: Remove wrapped `StacksPrivateKey` type in favor of simple type alias for string/Uint8Array. * test: update bns tests * chore: update cli (#1656) Co-authored-by: janniks <[email protected]> * feat!: Make serialize methods return hex-encoded strings, instead of bytes * docs: update migration guide * fix!: Remove legacy CLI methods * refactor: decrease circular deps in tx package * build: fix typedoc build * ci: update pr version detetction * fix!: Disable legacy triplesec support for mnemonic encryption BREAKING CHANGE: Support for encrypting/decrypting mnemonics using `triplesec` has been removed. * feat: Remove optional anchor mode from transaction options (#1654) Co-authored-by: janniks <[email protected]> * ci: update canary publishing * build: update lerna * fix: Add `.bootAddress` to network objects * chore: disable rule correctly * chore: reduce guessing tx version * refactor: add addressVersion to network object * refactor: consolidate address types * fix: Allow network name in more helper functions * refactor: move types * fix: Improve address helper functions * refactor!: Rename message types * refactor!: Make StacksTransaction.serialize() return a hex-string instead of bytes * refactor!: Rename more types to use "Wire" suffix * refactor!: Remove BN.js compatability * feat!: Update post-condition representation to human readable types * refactor: move internal wire types to reduce circular dependencies * refactor: add internal package for reusing test and other helpers * feat: Add postConditionToHex helper * fix: Allow .appendOrigin to be used with unwrapped public key * feat!: Rename networking/fetch methods to include `fetch` prefix * fix: Consolidate `is` prefixed boolean methods * chore: add comment * feat: Add STX unit helper methods * feat: Add `Address` namespace * feat: Add origin post-condition principals * refactor: minor updates * fix!: Remove signed option for intToBigInt * fix!: Move more helper functions to take network parameter * feat: Reduce wrapping of types for public key appending * refactor: Remove Serialize prefix from enum keys * refactor!: Remove wrapper type for message signatures * fix!: Compressing private key should ensure string format * refactor: Fix build breaking refactor changes * fix: Generate compressed private keys by default * refactor: Add renamed `randomSeedPhrase` method * refactor: Rename api to client and undo previous StacksNodeAPI changes * refactor: Continue client rename * test: Update to succeed tests * ci: update canary releases * fix: Remove legacy methods * chore: update comments * fix: Fix string parsing in structured signature decode * chore: Fix example in comment * refactor: Undo removal * fix!: Switch to a network and client param solution * chore: fix imports * docs: Update migration file * refactor: Minor refactoring to match common theme * refactor: Rename make methods * refactor: Deprecate wallet config * refactor: Remove unneeded deserialize overloads * refactor!: Update StacksTransaction constructor to options object * refactor!: Rename StacksTransaction to StacksTransactionWire * fix: Update post conditions input in transactions * chore: add forgotten rename * docs: Update migration guide * refactor: Change getStxAddress to use network parameter * refactor!: Update Cl.serialize to return string instead of bytes --------- Co-authored-by: janniks <[email protected]> Co-authored-by: Hugo C <[email protected]>

janniks linked an issue Mar 11, 2024 that may be closed by this pull request

[Nakamoto] Remove anchor-mode #1578

Open

janniks changed the base branch from main to nakamoto March 11, 2024 15:06

vercel bot deployed to Preview March 11, 2024 15:07 View deployment

janniks force-pushed the 1578-nakamoto-remove-anchor-mode branch 2 times, most recently from db80837 to 1065edc Compare March 11, 2024 15:13

vercel bot deployed to Preview March 11, 2024 15:15 View deployment

janniks force-pushed the nakamoto branch from 77387d3 to fe22dc5 Compare March 12, 2024 01:36

janniks force-pushed the 1578-nakamoto-remove-anchor-mode branch from 1065edc to 16afc0d Compare March 12, 2024 12:04

vercel bot deployed to Preview March 12, 2024 12:06 View deployment

janniks force-pushed the 1578-nakamoto-remove-anchor-mode branch from 16afc0d to 89eb6ea Compare March 12, 2024 12:09

vercel bot deployed to Preview March 12, 2024 12:11 View deployment

janniks force-pushed the nakamoto branch 2 times, most recently from 2af8f23 to b00840a Compare March 18, 2024 15:44

janniks force-pushed the 1578-nakamoto-remove-anchor-mode branch from 89eb6ea to 22339fb Compare March 22, 2024 14:22

janniks requested a review from MicaiahReid March 22, 2024 14:22

vercel bot deployed to Preview March 22, 2024 14:23 View deployment

janniks force-pushed the nakamoto branch from 325cf6c to d3d4c54 Compare March 22, 2024 16:58

janniks force-pushed the 1578-nakamoto-remove-anchor-mode branch from 22339fb to 17dee7b Compare March 22, 2024 17:00

vercel bot deployed to Preview March 22, 2024 17:01 View deployment

janniks force-pushed the nakamoto branch 2 times, most recently from 990becd to 9c2f45e Compare March 22, 2024 20:03

Base automatically changed from nakamoto to main March 22, 2024 20:19

MicaiahReid approved these changes Mar 22, 2024

View reviewed changes

packages/stacking/src/utils.ts Outdated Show resolved Hide resolved

janniks force-pushed the 1578-nakamoto-remove-anchor-mode branch from 17dee7b to 8e80adc Compare May 13, 2024 11:32

vercel bot deployed to Preview May 13, 2024 11:33 View deployment

janniks force-pushed the 1578-nakamoto-remove-anchor-mode branch from 8e80adc to f58b754 Compare May 13, 2024 13:01

vercel bot deployed to Preview May 13, 2024 13:03 View deployment

janniks changed the base branch from main to remove-legacy-triplesec-support May 13, 2024 13:05

janniks force-pushed the 1578-nakamoto-remove-anchor-mode branch from f58b754 to 512cb36 Compare May 28, 2024 02:47

vercel bot deployed to Preview May 28, 2024 02:51 View deployment

janniks force-pushed the 1578-nakamoto-remove-anchor-mode branch from 512cb36 to 3a1bdd1 Compare May 28, 2024 02:52

vercel bot deployed to Preview May 28, 2024 02:54 View deployment

janniks force-pushed the remove-legacy-triplesec-support branch from 6ec9048 to 4721d1a Compare May 28, 2024 20:23

janniks force-pushed the 1578-nakamoto-remove-anchor-mode branch from 3a1bdd1 to 45e12d1 Compare May 28, 2024 20:23

vercel bot deployed to Preview May 28, 2024 20:26 View deployment

janniks force-pushed the remove-legacy-triplesec-support branch from 4721d1a to 0eb233b Compare June 10, 2024 12:38

janniks force-pushed the 1578-nakamoto-remove-anchor-mode branch from 45e12d1 to 04b96a7 Compare June 10, 2024 12:39

vercel bot deployed to Preview June 10, 2024 12:44 View deployment

janniks force-pushed the remove-legacy-triplesec-support branch from 0eb233b to 94b2f5d Compare June 10, 2024 13:48

janniks force-pushed the 1578-nakamoto-remove-anchor-mode branch from 04b96a7 to 22752ff Compare June 10, 2024 13:48

vercel bot deployed to Preview June 10, 2024 14:01 View deployment

janniks force-pushed the remove-legacy-triplesec-support branch from 94b2f5d to 3e09560 Compare June 10, 2024 15:07

janniks force-pushed the 1578-nakamoto-remove-anchor-mode branch 2 times, most recently from 00d4bfe to cbf6ad1 Compare June 10, 2024 15:14

janniks force-pushed the remove-legacy-triplesec-support branch from 3e09560 to 5750984 Compare June 10, 2024 15:14

janniks force-pushed the 1578-nakamoto-remove-anchor-mode branch from cbf6ad1 to d798285 Compare June 10, 2024 15:17

janniks force-pushed the remove-legacy-triplesec-support branch 2 times, most recently from fdcb76d to e6f4c12 Compare June 10, 2024 15:20

janniks force-pushed the 1578-nakamoto-remove-anchor-mode branch from d798285 to 1884150 Compare June 10, 2024 15:20

Base automatically changed from remove-legacy-triplesec-support to next June 10, 2024 15:22

feat: remove optional anchor mode from transaction options

ca3756a

janniks force-pushed the 1578-nakamoto-remove-anchor-mode branch from 1884150 to ca3756a Compare June 10, 2024 15:23

janniks merged commit 2bec7ae into next Jun 10, 2024
7 of 8 checks passed

janniks deleted the 1578-nakamoto-remove-anchor-mode branch June 10, 2024 15:27

vercel bot deployed to Preview June 10, 2024 15:29 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1578 nakamoto remove anchor mode #1654

1578 nakamoto remove anchor mode #1654

janniks commented Mar 11, 2024 •

edited by github-actions bot

Loading

vercel bot commented Mar 11, 2024 •

edited

Loading

codecov bot commented Mar 11, 2024 •

edited

Loading

MicaiahReid left a comment

janniks commented May 13, 2024 •

edited

Loading

1578 nakamoto remove anchor mode #1654

1578 nakamoto remove anchor mode #1654

Conversation

janniks commented Mar 11, 2024 • edited by github-actions bot Loading

vercel bot commented Mar 11, 2024 • edited Loading

codecov bot commented Mar 11, 2024 • edited Loading

Codecov Report

MicaiahReid left a comment

Choose a reason for hiding this comment

janniks commented May 13, 2024 • edited Loading

janniks commented Mar 11, 2024 •

edited by github-actions bot

Loading

vercel bot commented Mar 11, 2024 •

edited

Loading

codecov bot commented Mar 11, 2024 •

edited

Loading

janniks commented May 13, 2024 •

edited

Loading