Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: BTC explorer network config #1306

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

He1DAr
Copy link
Collaborator

@He1DAr He1DAr commented Oct 13, 2023

Introduce new environment variables to configure BTC explorer base URL:

NEXT_PUBLIC_MAINNET_BTC_BLOCK_BASE_URL (defaults to 'https://mempool.space/block')
NEXT_PUBLIC_MAINNET_BTC_TX_BASE_URL (defaults to 'https://mempool.space/tx')
NEXT_PUBLIC_MAINNET_BTC_ADDRESS_BASE_URL (defaults to 'https://mempool.space/address')

NEXT_PUBLIC_TESTNET_BTC_BLOCK_BASE_URL (defaults to 'https://mempool.space/testnet/block')
NEXT_PUBLIC_TESTNET_BTC_TX_BASE_URL (defaults to 'https://mempool.space/testnet/tx')
NEXT_PUBLIC_TESTNET_BTC_ADDRESS_BASE_URL (defaults to 'https://mempool.space/testnet/address')

Add BTC explorer fields to custom network form:

image image

closes #1296

@vercel
Copy link

vercel bot commented Oct 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hiro-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2023 1:05pm

@He1DAr He1DAr force-pushed the feat/btc-explorer-network-config branch from aeba326 to 6912233 Compare October 13, 2023 13:04
@He1DAr He1DAr temporarily deployed to k8s-dev October 13, 2023 13:07 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #1306 (6912233) into main (47c86dd) will increase coverage by 0.16%.
Report is 3 commits behind head on main.
The diff coverage is 39.28%.

@@            Coverage Diff             @@
##             main    #1306      +/-   ##
==========================================
+ Coverage   23.95%   24.11%   +0.16%     
==========================================
  Files         454      456       +2     
  Lines        6671     6730      +59     
  Branches     1706     1735      +29     
==========================================
+ Hits         1598     1623      +25     
- Misses       4907     4938      +31     
- Partials      166      169       +3     
Files Coverage Δ
src/app/Providers.tsx 0.00% <ø> (ø)
src/common/constants.ts 88.46% <100.00%> (+3.46%) ⬆️
src/common/constants/network.ts 100.00% <100.00%> (ø)
src/common/types/network.ts 100.00% <ø> (ø)
src/components/btc-stx-block-links.tsx 78.26% <100.00%> (-1.74%) ⬇️
src/components/modals/AddNetwork/utils.ts 100.00% <100.00%> (ø)
src/app/txid/[txid]/Cards/BtcAnchorBlockCard.tsx 0.00% <0.00%> (ø)
src/components/app-config.tsx 0.00% <0.00%> (ø)
src/components/function-summary/value.tsx 44.00% <0.00%> (-0.24%) ⬇️
src/components/modals.tsx 0.00% <0.00%> (ø)
... and 8 more

... and 1 file with indirect coverage changes

@He1DAr He1DAr merged commit b50f2da into main Oct 23, 2023
12 of 13 checks passed
@He1DAr He1DAr deleted the feat/btc-explorer-network-config branch October 23, 2023 14:21
@blockstack-devops
Copy link

🎉 This PR is included in version 1.126.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Prep for the hackathon: running regtest locally
2 participants