Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for the hackathon: running regtest locally #1296

Closed
andresgalante opened this issue Oct 2, 2023 · 4 comments · Fixed by #1306
Closed

Prep for the hackathon: running regtest locally #1296

andresgalante opened this issue Oct 2, 2023 · 4 comments · Fixed by #1306
Assignees
Labels

Comments

@andresgalante
Copy link
Member

We'd like the locally running stack-explorer to direct to the locally running regtest blockchain explorer instead of the default testnet blockchain explorer.

We've prepped the sBTC repo for the hackathon with a devnet, where within this devenv directory the hackers can spin up a docker compose file that launches a bunch of services. You can give it a look here: link

When we use the stacks explorer locally clicking on the bitcoin block number directs us to the default testnet blockchain explorer. We'd like it to connect to the explorer that shows the regtest bitcoin block. This would only be relevant when the stacks explorer is running locally so I'd think an environment variable or configuration for the container running stacks explorer would be sufficient.

There is a video of the issue here https://github.com/hirosystems/explorer/assets/1832037/78ad310b-0ce3-4bc3-bcc6-18f54f73d0bc

And an branch with an (unfinished fix) has been started here: https://github.com/EmbeddedAndroid/explorer/commits/cfg-btc-endpoint

@github-project-automation github-project-automation bot moved this to 🆕 New in Stacks Explorer Oct 2, 2023
@andresgalante andresgalante changed the title Prep for the hackathon: running regtest locally instead of testnet Prep for the hackathon: running regtest locally Oct 2, 2023
@He1DAr
Copy link
Collaborator

He1DAr commented Oct 6, 2023

We can customize the base BTC explorer URL (https://mempool.space/block/https://mempool.space/block/testnet) using an environment variable. Additionally, we can introduce a new optional field "BTC explorer base URL" when adding a custom network, so the final BTC block URL would look like: ${BTC_EXPLORER_BASE_URL}/${btcBlockHeight}

@EmbeddedAndroid
Copy link

We can customize the base BTC explorer URL (https://mempool.space/block/https://mempool.space/block/testnet) using an environment variable. Additionally, we can introduce a new optional field "BTC explorer base URL" when adding a custom network, so the final BTC block URL would look like: ${BTC_EXPLORER_BASE_URL}/${btcBlockHeight}

This sounds like a good solution to me, thanks for the consideration!

@He1DAr He1DAr self-assigned this Oct 6, 2023
@andresgalante andresgalante moved this from 🆕 New to 📋 Backlog in Stacks Explorer Oct 10, 2023
@He1DAr
Copy link
Collaborator

He1DAr commented Oct 13, 2023

@EmbeddedAndroid here's the PR #1306, also deployed to dev https://explorer.dev.hiro.so/?chain=mainnet
Please let me know if you have any suggestions. I'm looking forward to your feedback!

@He1DAr He1DAr moved this from 📋 Backlog to 🏗 In progress in Stacks Explorer Oct 13, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Stacks Explorer Oct 23, 2023
@blockstack-devops
Copy link

🎉 This issue has been resolved in version 1.126.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants