Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate onboarding feature from XML to Jetpack Compose #179

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Migrate onboarding feature from XML to Jetpack Compose #179

merged 1 commit into from
Oct 1, 2023

Conversation

Devendra34
Copy link
Contributor

@Devendra34 Devendra34 commented Oct 1, 2023 •
edited
Loading

Onboarding in Jetpack Compose (Fixes #176)

  • Implemented OnboardingScreen Composable
  • Deleted activity_onboarding.xml file

Composable tree

  • OnboardingScreen (Box)
    • OnboardingScreenBackground (Image bg)
    • OnboardingScreenContent (Column with bottom alignment)
      • Carrot logo (Image)
      • Welcome text 1 (Text)
      • Welcome text 2 (Text)
      • Get Started (PrimaryButton)

Core widgets

  • PrimaryButton
  • SecondaryButton

Screenshot

Onboarding

Screenshot_20231001_160508

PrimaryButton

Ignore Preview layout bounds of blue color
ezgif com-video-to-gif

@Devendra34 Devendra34 mentioned this pull request Oct 1, 2023
Closed
@hieuwu
Copy link
Owner

hieuwu commented Oct 1, 2023

Hi @Devendra34 , would you mind updating some screenshot? It would be easier for me to review the change. Thanks a lot

@Devendra34
Copy link
Contributor Author

Sure @hieuwu,
Updated the PR description with screenshot.
Since there was no visual UI change, I was unsure whether to include it or not.

@hieuwu
Copy link
Owner

hieuwu commented Oct 1, 2023

Looks good to me. Feel free to raise anything you want to add to the project @Devendra34 . Thank you so much for your contribution ! 👍

@hieuwu hieuwu merged commit d714baa into hieuwu:main Oct 1, 2023
2 checks passed
@hieuwu hieuwu self-requested a review October 1, 2023 13:32
@Devendra34
Copy link
Contributor Author

Devendra34 commented Oct 1, 2023 •
edited
Loading

Looks good to me. Feel free to raise anything you want to add to the project @Devendra34 . Thank you so much for your contribution ! 👍

Thank you @hieuwu. 🙌
If you like my work, I'm happy to contribute for other Compose Migration issues as well. Requested #173 as of now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hieuwu hieuwu Awaiting requested review from hieuwu

Assignees

@Devendra34 Devendra34

Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate onboarding to Jetpack Compose
2 participants
@Devendra34 @hieuwu