Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate onboarding to Jetpack Compose #176

Closed
hieuwu opened this issue Sep 30, 2023 · 6 comments · Fixed by #179
Closed

Migrate onboarding to Jetpack Compose #176

hieuwu opened this issue Sep 30, 2023 · 6 comments · Fixed by #179
Assignees
Labels

Comments

@hieuwu
Copy link
Owner

hieuwu commented Sep 30, 2023

Currently feature Account in presentation/onboarding package is implemented with XML view system. Let's convert it to Jetpack Compose. See shop feature for reference

@hieuwu hieuwu added the good first issue Good for newcomers label Sep 30, 2023
@Devendra34
Copy link
Contributor

Hi @hieuwu,
Can I work on this Issue?

@hieuwu
Copy link
Owner Author

hieuwu commented Oct 1, 2023

Hi @hieuwu,
Can I work on this Issue?

Sure. I assigned it to you. Let me know if you need any help

@Devendra34
Copy link
Contributor

Devendra34 commented Oct 1, 2023

Hi @hieuwu,
What is the expected primary button disabled color? Is it light_gray or transparent?
From the primary_button.xml code it seems like light_gray, but when we run the app or even in andriod studio xml previews, it looks like transparent.

Observe the preview in this screenshot
Screenshot 2023-10-01 at 12 49 53 PM

primary_button.xml snippet for disabled color
Screenshot 2023-10-01 at 12 51 26 PM

@Devendra34
Copy link
Contributor

Hi @hieuwu, What is the expected primary button disabled color? Is it light_gray or transparent? From the primary_button.xml code it seems like light_gray, but when we run the app or even in andriod studio xml previews, it looks like transparent.

Observe the preview in this screenshot Screenshot 2023-10-01 at 12 49 53 PM

primary_button.xml snippet for disabled color Screenshot 2023-10-01 at 12 51 26 PM

Compared with fragment_account.xml, the property app:backgroundTint="@null" was missing in activity_onboarding.xml'. Because of this the disabled color was not updated.

Going forward with light_gray color in compose. The xml file will be anyhow deleted.

@hieuwu
Copy link
Owner Author

hieuwu commented Oct 1, 2023

Hi @hieuwu, What is the expected primary button disabled color? Is it light_gray or transparent? From the primary_button.xml code it seems like light_gray, but when we run the app or even in andriod studio xml previews, it looks like transparent.

Observe the preview in this screenshot Screenshot 2023-10-01 at 12 49 53 PM

primary_button.xml snippet for disabled color Screenshot 2023-10-01 at 12 51 26 PM

Yeah good catch @Devendra34 . Let's go with your solution because that makes sense

@Devendra34
Copy link
Contributor

Thanks for the confirmation @hieuwu.
I have raise #179 based on our discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants