Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump fun_run #233

Closed
wants to merge 2 commits into from
Closed

Bump fun_run #233

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03b93dc
Bump fun_run
Nov 6, 2023
7f0af10
Merge branch 'main' into schneems/bump-fun-run
schneems Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion commons/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ thiserror = "1"
walkdir = "2"
ascii_table = { version = "4", features = ["color_codes"] }
const_format = "0.2"
fun_run = "0.1"
fun_run = "0.1.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing style used in this repo (and across all of our CNB repos) is to only put the major version in Cargo.toml and leave version resolution within that major version range to the lockfile.

Copy link
Member

@edmorley edmorley Nov 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schneems I've triggered a Dependabot run manually now - which opened #234, that contains the fun_run update (amongst a couple of small other updates).

One thing I noticed that was the fun_run crate is missing some metadata (such as the GitHub repo URL) - which is why the changelog didn't show up on the Dependabot PR, and why there is no GitHub repo link on the crates.io page:
https://crates.io/crates/fun_run

For an example of the metadata you might want to include, see libcnb's manifest:
https://github.com/heroku/libcnb.rs/blob/5ab4b036a8dd18dc2d25a3d3ee49ed66ef3ec9d3/libcnb/Cargo.toml#L7-L12

The upstream docs have some more details on each of those fields:
https://doc.rust-lang.org/cargo/reference/manifest.html


[dev-dependencies]
indoc = "2"
Expand Down