Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump fun_run #233

Closed
wants to merge 2 commits into from
Closed

Bump fun_run #233

wants to merge 2 commits into from

Conversation

schneems
Copy link
Contributor

@schneems schneems commented Nov 6, 2023

Fixes double indenting the first line of streamed commands schneems/fun_run#3

Fixes double indenting the first line of streamed commands schneems/fun_run#3
@schneems schneems requested a review from a team as a code owner November 6, 2023 21:39
@schneems schneems enabled auto-merge (squash) November 6, 2023 21:44
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quicker way to pick up updates like this (that saves having to create a PR manually or wait for review) is to trigger a manual Dependabot run.

To do this, go to "Insights" -> Dependency graph -> Dependabot -> click "Recent update jobs" for the Cargo job type, which lands you on this page:
https://github.com/heroku/buildpacks-ruby/network/updates/15241710/jobs

From there, press "Check for updates" - and Dependabot will start a new run :-)

@@ -28,7 +28,7 @@ thiserror = "1"
walkdir = "2"
ascii_table = { version = "4", features = ["color_codes"] }
const_format = "0.2"
fun_run = "0.1"
fun_run = "0.1.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing style used in this repo (and across all of our CNB repos) is to only put the major version in Cargo.toml and leave version resolution within that major version range to the lockfile.

Copy link
Member

@edmorley edmorley Nov 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schneems I've triggered a Dependabot run manually now - which opened #234, that contains the fun_run update (amongst a couple of small other updates).

One thing I noticed that was the fun_run crate is missing some metadata (such as the GitHub repo URL) - which is why the changelog didn't show up on the Dependabot PR, and why there is no GitHub repo link on the crates.io page:
https://crates.io/crates/fun_run

For an example of the metadata you might want to include, see libcnb's manifest:
https://github.com/heroku/libcnb.rs/blob/5ab4b036a8dd18dc2d25a3d3ee49ed66ef3ec9d3/libcnb/Cargo.toml#L7-L12

The upstream docs have some more details on each of those fields:
https://doc.rust-lang.org/cargo/reference/manifest.html

@schneems schneems closed this Nov 28, 2023
auto-merge was automatically disabled November 28, 2023 21:03

Pull request was closed

@edmorley edmorley deleted the schneems/bump-fun-run branch November 28, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants