Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/kube-slack] Kube slack image from different CR #21915

Merged
merged 4 commits into from
Apr 14, 2020
Merged

[stable/kube-slack] Kube slack image from different CR #21915

merged 4 commits into from
Apr 14, 2020

Conversation

pierluigilenoci
Copy link
Contributor

What this PR does / why we need it:

Sometimes, for various reasons, there is interest in using the chart with a proprietary container adapted to particolar needs. Specifically, kube-slack does not natively support the Pod Security Policy.

Which issue this PR fixes

wongnai/kube-slack#65

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 14, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @pierluigilenoci. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 14, 2020
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Apr 14, 2020
@pierluigilenoci pierluigilenoci changed the title [stable/kube-slack] Kube slack image from different cr [stable/kube-slack] Kube slack image from different CR Apr 14, 2020
@pierluigilenoci
Copy link
Contributor Author

/assign @jstriebel

@zanhsieh
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 14, 2020
@pierluigilenoci
Copy link
Contributor Author

@zanhsieh A really strange job test error
Error: could not find a ready tiller pod 😮

@pierluigilenoci
Copy link
Contributor Author

/retest

@pierluigilenoci
Copy link
Contributor Author

Now only LGTM label is needed @zanhsieh @jstriebel
Thank you

@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Apr 14, 2020
In this way works better
449561a 
Signed-off-by: Pierluigi Lenoci <[email protected]>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Apr 14, 2020
jstriebel
jstriebel approved these changes Apr 14, 2020
View reviewed changes
Copy link
Collaborator

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks for the latest change 👍
/lgtm

stable/kube-slack/templates/deployment.yaml Outdated
@@ -41,6 +41,10 @@ spec:
- configMapRef:
name: {{ template "kube-slack.fullname" . }}
resources:
{{- if .Values.imagePullSecrets }}
imagePullSecrets:
- name: {{ .Values.imagePullSecrets | quote }}

This comment was marked as outdated.

Sign in to view

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstriebel, pierluigilenoci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Apr 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit 05d451d into helm:master Apr 14, 2020
@pierluigilenoci pierluigilenoci deleted the kube_slack_image_from_different_cr branch April 16, 2020 14:40
@jstriebel jstriebel mentioned this pull request Apr 20, 2020
Closed
4 tasks
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
@pierluigilenoci
[stable/kube-slack] Kube slack image from different CR (helm#21915)
a750d78 
* [stable/kube-slack] Added imagePullSecrets option to chart

Signed-off-by: Pierluigi Lenoci <[email protected]>

* In this way works better

Signed-off-by: Pierluigi Lenoci <[email protected]>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
@pierluigilenoci @includerandom
[stable/kube-slack] Kube slack image from different CR (helm#21915)
33c90ea 
* [stable/kube-slack] Added imagePullSecrets option to chart

Signed-off-by: Pierluigi Lenoci <[email protected]>

* In this way works better

Signed-off-by: Pierluigi Lenoci <[email protected]>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@pierluigilenoci @li-adrienloiseau
[stable/kube-slack] Kube slack image from different CR (helm#21915)
ab9cc18 
* [stable/kube-slack] Added imagePullSecrets option to chart

Signed-off-by: Pierluigi Lenoci <[email protected]>

* In this way works better

Signed-off-by: Pierluigi Lenoci <[email protected]>
Signed-off-by: Adrien Loiseau <[email protected]>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@pierluigilenoci
[stable/kube-slack] Kube slack image from different CR (helm#21915)
2c4dca0 
* [stable/kube-slack] Added imagePullSecrets option to chart

Signed-off-by: Pierluigi Lenoci <[email protected]>

* In this way works better

Signed-off-by: Pierluigi Lenoci <[email protected]>
Signed-off-by: Miguel Mingorance <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jstriebel jstriebel jstriebel approved these changes

@paulczar paulczar Awaiting requested review from paulczar

Assignees

@jstriebel jstriebel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pierluigilenoci @k8s-ci-robot @zanhsieh @jstriebel @helm-bot