Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/kube-slack] To run kube-slack as non root #21983

Closed
wants to merge 1 commit into from
Closed

[stable/kube-slack] To run kube-slack as non root #21983

wants to merge 1 commit into from

Conversation

pierluigilenoci
Copy link
Contributor

What this PR does / why we need it:

To run kube-slack as non root

Which issue this PR fixes

No issue to fix, only an improvement.

Special notes for your reviewer:

I had to delete my fork and recreate it, sorry for that.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pierluigilenoci
To complete the pull request process, please assign jstriebel
You can assign the PR to them by writing /assign @jstriebel in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @pierluigilenoci. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 17, 2020
@pierluigilenoci
Copy link
Contributor Author

Previous PR #21967

@zanhsieh
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 17, 2020
@pierluigilenoci
Copy link
Contributor Author

/assign @jstriebel

@pierluigilenoci
Copy link
Contributor Author

/retest

@@ -41,10 +43,6 @@ spec:
- configMapRef:
name: {{ template "kube-slack.fullname" . }}
resources:
{{ if .Values.image.pullSecret }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pierluigilenoci This is undoing your changes from #21915, which is probably not intended. Maybe you just need to merge the upstream master branch from helm/charts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is undoing my changes from #21915 on purpose because was useless and even a broken solution. This new PR is a better approach to solve the problem.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Why exactly was it broken? In my opinion it would be better to fix the pullSecret usage, instead of removing it, since somebody else might still need it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use my solution you get something like that

imagePullSecrets:
        - name: yoursecret {}

with an extra {} and I was not able to fix it because in this moment I don't have the time to eat my brain out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I preferred to remove it in favor of a solution that worked for what my needs were. That is to make this chart compatible with the pod security policy. Not the best solution ever but at least the chart is not broken.

@stale
Copy link

stale bot commented May 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 21, 2020
@pierluigilenoci pierluigilenoci requested a review from jstriebel May 22, 2020 08:51
@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 22, 2020
@stale
Copy link

stale bot commented Jun 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 21, 2020
@stale
Copy link

stale bot commented Jul 6, 2020

This issue is being automatically closed due to inactivity.

@stale stale bot closed this Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants