Haven 4.0.3 - fix difficulty drift and removal of stuck conversions from the pool after 1 hour #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a difference in the precision of difficulty calculation between Linux x86_64 and Windows / Linux ARM8. It seems to relate to floating point arithmetic deviations, most likely coming from the additional -m64 flag (rounding to 53 bits) passed in linux.mk in the make depend configuration. Changing the type to long double seems to fix the issue and produce consistent results between Linux x86_64 and other Windows / Linux ARM8.
|
changes will be included in Haven 4.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a difference in the precision of difficulty calculation between Linux x86_64 and Windows / Linux ARM8. It seems to relate to floating point arithmetic deviations, most likely coming from the additional -m64 flag (rounding to 53 bits) passed in linux.mk in the make depend configuration. Changing the type to long double seems to fix the issue and produce consistent results between Linux x86_64 and other Windows / Linux ARM8.
Additionally, add a 1 hour time limit of conversions remaining the transaction pool, as a temporary measure to help the current stuck transactions problem.