Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw startServer exceptions synchronously #86

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Throw startServer exceptions synchronously #86

wants to merge 2 commits into from

Commits on Oct 9, 2021

  1. throw startServer exceptions synchronously 

    Error handling doesn't currently work with `forkServer`:
```
do
  s <- Just <$> forkServer "localhost" 8000 `catchAny` \e -> pure Nothing
```

The above code will not manage to deal with "port already in use" or similar, since the exceptions are being thrown asynchronously to the main thread.

To address that we use an Async to hold the server, so there's no longer a need to throw the exception back to the main thread.
    @pepeiborra
    pepeiborra committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    9b4e480 View commit details
    Browse the repository at this point in the history

  2. bump version

    @pepeiborra
    pepeiborra committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    88dc2e1 View commit details
    Browse the repository at this point in the history