Throw startServer exceptions synchronously #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error handling doesn't currently work with `forkServer`: ``` do s <- Just <$> forkServer "localhost" 8000 `catchAny` \e -> pure Nothing ``` The above code will not manage to deal with "port already in use" or similar, since the exceptions are being thrown asynchronously to the main thread. To address that we use an Async to hold the server, so there's no longer a need to throw the exception back to the main thread.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error handling doesn't currently work with
forkServer:The above code will not manage to deal with "port already in use" or similar, since the exceptions are being thrown asynchronously to the main thread.
To address that we use an Async to hold the server, so there's no longer a need to throw the exception back to the main thread.