Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added HBar rate limiter to createFile #2634

Merged
merged 8 commits into from
Jun 29, 2024

Conversation

ebadiere
Copy link
Contributor

Added HBar rate limiting to sdkClient.createFile.

Related issue(s):

Fixes #2631

@ebadiere ebadiere requested review from AlfredoG87, lukelee-sl and a team as code owners June 28, 2024 17:42
@ebadiere ebadiere self-assigned this Jun 28, 2024
@ebadiere ebadiere added the bug Something isn't working label Jun 28, 2024
@ebadiere ebadiere added this to the 0.50.0 milestone Jun 28, 2024
@ebadiere ebadiere closed this Jun 28, 2024
@ebadiere ebadiere reopened this Jun 28, 2024
Copy link

github-actions bot commented Jun 28, 2024

Tests

    2 files  158 suites   14s ⏱️
855 tests 854 ✔️ 1 💤 0
867 runs  866 ✔️ 1 💤 0

Results for commit 2abe545.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 28, 2024

Acceptance Tests

  17 files  218 suites   31m 0s ⏱️
603 tests 598 ✔️ 4 💤 1
711 runs  706 ✔️ 4 💤 1

Results for commit 0665411.

♻️ This comment has been updated with latest results.

quiet-node
quiet-node previously approved these changes Jun 28, 2024
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nana-EC
Nana-EC previously approved these changes Jun 28, 2024
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblocking but please correct the logging item.
The rest can be done in follow up

packages/relay/src/lib/clients/sdkClient.ts Outdated Show resolved Hide resolved
packages/relay/src/lib/clients/sdkClient.ts Outdated Show resolved Hide resolved
packages/relay/tests/lib/sdkClient.spec.ts Show resolved Hide resolved
Co-authored-by: Nana Essilfie-Conduah <[email protected]>
Signed-off-by: Eric Badiere <[email protected]>
@ebadiere ebadiere dismissed stale reviews from Nana-EC and quiet-node via e4c9c4d June 28, 2024 23:13
Signed-off-by: Logan Nguyen <[email protected]>
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion provided

packages/relay/src/lib/clients/sdkClient.ts Outdated Show resolved Hide resolved
Signed-off-by: ebadiere <[email protected]>
Copy link

@ebadiere ebadiere merged commit 1dc6552 into main Jun 29, 2024
32 of 33 checks passed
@ebadiere ebadiere deleted the 2631-add-hbar-rateLimiter-to-createFile-added branch June 29, 2024 01:07
quiet-node added a commit that referenced this pull request Jun 29, 2024
* fix: Added HBar rate limiter to createFile

Signed-off-by: ebadiere <[email protected]>

* fix: Build fix and applied feedback.

Signed-off-by: ebadiere <[email protected]>

* fix: removed duplicated query & added return statement

Signed-off-by: Logan Nguyen <[email protected]>

* Update packages/relay/src/lib/clients/sdkClient.ts

Co-authored-by: Nana Essilfie-Conduah <[email protected]>
Signed-off-by: Eric Badiere <[email protected]>

* fix: removed unused variable

Signed-off-by: Logan Nguyen <[email protected]>

* fix: Applied feedback

Signed-off-by: ebadiere <[email protected]>

* fix: Fixed scope.

Signed-off-by: ebadiere <[email protected]>

---------

Signed-off-by: ebadiere <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Eric Badiere <[email protected]>
Co-authored-by: Logan Nguyen <[email protected]>
Co-authored-by: Nana Essilfie-Conduah <[email protected]>
Nana-EC added a commit that referenced this pull request Jun 29, 2024
* fix: Added HBar rate limiter to createFile



* fix: Build fix and applied feedback.



* fix: removed duplicated query & added return statement



* Update packages/relay/src/lib/clients/sdkClient.ts




* fix: removed unused variable



* fix: Applied feedback



* fix: Fixed scope.



---------

Signed-off-by: ebadiere <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Eric Badiere <[email protected]>
Co-authored-by: Eric Badiere <[email protected]>
Co-authored-by: Nana Essilfie-Conduah <[email protected]>
@Nana-EC Nana-EC modified the milestones: 0.50.0, 0.51.0 Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add rateLimiter to the create file in the sdkClient
3 participants