-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Added HBar rate limiter to createFile #2634
Conversation
Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unblocking but please correct the logging item.
The rest can be done in follow up
Co-authored-by: Nana Essilfie-Conduah <[email protected]> Signed-off-by: Eric Badiere <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion provided
Signed-off-by: ebadiere <[email protected]>
…://github.com/hashgraph/hedera-json-rpc-relay into 2631-add-hbar-rateLimiter-to-createFile-added Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
Quality Gate passedIssues Measures |
* fix: Added HBar rate limiter to createFile Signed-off-by: ebadiere <[email protected]> * fix: Build fix and applied feedback. Signed-off-by: ebadiere <[email protected]> * fix: removed duplicated query & added return statement Signed-off-by: Logan Nguyen <[email protected]> * Update packages/relay/src/lib/clients/sdkClient.ts Co-authored-by: Nana Essilfie-Conduah <[email protected]> Signed-off-by: Eric Badiere <[email protected]> * fix: removed unused variable Signed-off-by: Logan Nguyen <[email protected]> * fix: Applied feedback Signed-off-by: ebadiere <[email protected]> * fix: Fixed scope. Signed-off-by: ebadiere <[email protected]> --------- Signed-off-by: ebadiere <[email protected]> Signed-off-by: Logan Nguyen <[email protected]> Signed-off-by: Eric Badiere <[email protected]> Co-authored-by: Logan Nguyen <[email protected]> Co-authored-by: Nana Essilfie-Conduah <[email protected]>
* fix: Added HBar rate limiter to createFile * fix: Build fix and applied feedback. * fix: removed duplicated query & added return statement * Update packages/relay/src/lib/clients/sdkClient.ts * fix: removed unused variable * fix: Applied feedback * fix: Fixed scope. --------- Signed-off-by: ebadiere <[email protected]> Signed-off-by: Logan Nguyen <[email protected]> Signed-off-by: Eric Badiere <[email protected]> Co-authored-by: Eric Badiere <[email protected]> Co-authored-by: Nana Essilfie-Conduah <[email protected]>
Added HBar rate limiting to sdkClient.createFile.
Related issue(s):
Fixes #2631