fix: Added rateLimiter to fileCreate. #2632
Conversation
Signed-off-by: ebadiere <[email protected]>
| @@ -257,7 +257,7 @@ export class SDKClient { | |||
| fileId = await this.createFile( | |||
| ethereumTransactionData.callData, | |||
| this.clientMain, | |||
| requestId, | |||
| requestId ?? 'create-file-from-submit-ethereum-transaction', | |||
There was a problem hiding this comment.
The optional parameter on the requestId causes Argument of type 'string | undefined' is not assignable to parameter of type 'string'.. I can remove the optional all the way to the sendRawTransaction
There was a problem hiding this comment.
My concern is the choice of string.
Doesn't seem consistent with anything we've done.
Either the requestId is provided by a user of one is generated higher up if not present.
Why do we need this workaround only here?
|
|
||
| // Ensure that the calldata file is not empty | ||
| if (fileId) { | ||
| const fileSize = await (await new FileInfoQuery().setFileId(fileId).execute(client)).size; |
There was a problem hiding this comment.
Q: does this have a cost associated with it?
If so can you open a ticket so we come back and see if this is needed still and more so also capture its cost in the metric and rate limits
| interactingEntity, | ||
| ); | ||
|
|
||
| this.hbarLimiter.addExpense(transactionFee.toTinybars().toNumber(), currentDateNow); |
There was a problem hiding this comment.
This only adds the file create transaction cost.
What about the fileAppend transaction(s)?
| } | ||
|
|
||
| // Ensure that the calldata file is not empty | ||
| if (fileId) { |
There was a problem hiding this comment.
Q: Where's the actual logic to add the costs of the FileCreate and FileAppend to the hbar rate limiter?
Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
|
|
Replaced by #2634 |
Adds HBar rate limiter to the
createFilemethodRelated issue(s): #2631