Stop calling pause() before play promise resolved #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnoks
reviewed
Mar 2, 2023
scripts/html5.js
Outdated
| }) | ||
| .catch(function (error) { | ||
| video.pause(); // Fallback | ||
| }); |
There was a problem hiding this comment.
Same as the above comment:
playPromise.finally(() => video.pause());
There was a problem hiding this comment.
@fnoks Makes total sense! Done.
otacke
force-pushed
the
fix-pause-before-play-resolved
branch
from
d782b2c to
856263e
Compare
otacke
force-pushed
the
fix-pause-before-play-resolved
branch
from
856263e to
fdc00db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the HTML5 handler calls
video.pause()directly after callingvideo.play(), e.g. when switching from one quality version to another. This can result in a DOMException, because the play promise needs to be resolved first (please cmp. Google's developer guidelines).When merged in, this will be fixed by applying the pattern suggested in Google's developer guidelines and keep the current behavior as fallback for browsers that do not support promises.