New features: Add accessibility improvements #233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/scripts/interactive-video.js
Outdated
| var $listSignLanguage = $(''); | ||
| if (htmlSignLanguage !== '') { | ||
| var classesSignLanguage = 'h5p-interactive-video-menu-title'; | ||
| if (html !== 0) { |
There was a problem hiding this comment.
Condition should be html !== '' like this?
There was a problem hiding this comment.
That was in fact a little strange. Not sure how that found its way in there.
src/scripts/interactive-video.js
Outdated
| var classesSignLanguage = 'h5p-interactive-video-menu-title'; | ||
| if (html !== 0) { | ||
| // Only secondary title | ||
| classesSignLanguage += ' h5p-interactive-video-menu-title-secondary'; |
There was a problem hiding this comment.
When will this execute? Just related to above comment.
There was a problem hiding this comment.
That was a remnant of my previous implementation that could have sign language versions separately from the "qualities". Thanks for finding that.
|
Rejected despite pre-qualification |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged in, will allow to ...
Requires changes to
H5P Editor coreandH5P.Videoto take effect.pre-qualified by and implemented according to requests from @falcon-git
Bonus for H5P.Video: Stop calling pause() before play promise resolved