-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: graph-node-status-endpoint for DeploymentDetail status_url #91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've confirmed this is now working as expected on the local-network
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There may be an issue with the tests though. I restarted the job to see if it was a fluke.
There's definitely an issue with the tests:
@hopeyen could you try running the tests locally and see what happens? |
6d976f2
to
cf3d229
Compare
cf3d229
to
87f4651
Compare
Pull Request Test Coverage Report for Build 6811417087
💛 - Coveralls |
Indexer service takes in
DeploymentDetails::for_graph_node
currently generalizedgraph_node_base_url
for bothstatus_url
by appending/status
query_url
by appending/subgraphs/id/:id
I made updates to use the configured
--graph-node-status-endpoint
forstatus_url
instead ofgraph_node_query_endpoint
.Resolves #89