Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect subgraph indexing status check #89

Closed
Theodus opened this issue Nov 8, 2023 · 3 comments · Fixed by #91
Closed

incorrect subgraph indexing status check #89

Theodus opened this issue Nov 8, 2023 · 3 comments · Fixed by #91
Assignees
Labels
p1 High priority size:medium Medium type:bug Something isn't working

Comments

@Theodus
Copy link
Member

Theodus commented Nov 8, 2023

The behavior of monitor_deployment_status is incorrect for the following reasons:

  1. The query uses the wrong filter key, resulting in the expected 0 index value potentially being the status for a different deployment. It should be the following:
    query indexingStatuses($ids: [ID!]!) {
        indexingStatuses(subgraphs: $ids) {
            synced
            health
        }
    }
  2. The status_url is not the correct URL. On my local-network, it's set to http://172.17.0.1:8000/status instead of http://localhost:8030/graphql, despite the latter being set as --graph-node-status-endpoint.
    image
@hopeyen hopeyen self-assigned this Nov 8, 2023
@hopeyen hopeyen added size:medium Medium p1 High priority type:bug Something isn't working labels Nov 8, 2023
@hopeyen hopeyen added this to Indexer Nov 8, 2023
@github-project-automation github-project-automation bot moved this to 🗃️ Inbox in Indexer Nov 8, 2023
@hopeyen hopeyen moved this from 🗃️ Inbox to 🐛 Bug reports in Indexer Nov 8, 2023
@hopeyen
Copy link
Collaborator

hopeyen commented Nov 8, 2023

Hi Theo, thanks for the detail report!

Trying to understand the issue with

  1. The status_url is not the correct URL. On my local-network, it's set to http://172.17.0.1:8000/status instead of http://localhost:8030/graphql, despite the latter being set as --graph-node-status-endpoint.

indexer service exposes a /status endpoint for indexing statuses queries, it basically just routes the queries to --graph-node-status-endpoint. If you curl to http://172.17.0.1:8000/status, it should give you the same responses. Could you help me understand the issue a bit better?

@Theodus
Copy link
Member Author

Theodus commented Nov 8, 2023

It's possible that I'm misunderstanding how this should work, but one gives the expected response, the other just returns {"message": "Not found"} (using graph-node v0.33.0):
image

@hopeyen
Copy link
Collaborator

hopeyen commented Nov 8, 2023

I think I understood the problem, pls lmk if #91 fixes the problem with monitor_deployment_status; this doesn't change anything for the curl request to localhost/status, even though that should've worked for indexer service endpoint🤔

@github-project-automation github-project-automation bot moved this from 🐛 Bug reports to ❌ Closed in Indexer Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 High priority size:medium Medium type:bug Something isn't working
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

2 participants