Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): fix toolshed deps #118

Merged
merged 2 commits into from
Feb 6, 2024
Merged

build(deps): fix toolshed deps #118

merged 2 commits into from
Feb 6, 2024

Conversation

aasseman
Copy link
Contributor

@aasseman aasseman commented Feb 5, 2024

Fixed the versions of toolshed crates to proper tags.
Also, replaced direct usage of alloy_primitives::Address to the toolshed re-export thegraph::types::Address to enforce alloy version compatibility between indexer-rs and other projects that depend on toolshed.

Note that the tap_core dependency is based on a custom branch based off of tap_core v0.7.0 on which the same treatment was applied. This is temporary as for now tap_core's main branch contains a lot of breaking changes.

@aasseman aasseman added size:medium Medium p1 High priority labels Feb 5, 2024
@aasseman aasseman requested a review from hopeyen February 5, 2024 23:13
@aasseman aasseman self-assigned this Feb 5, 2024
Copy link
Contributor

github-actions bot commented Feb 5, 2024

Pull Request Test Coverage Report for Build 7792112354

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.23%

Totals Coverage Status
Change from base Build 7762887178: 0.0%
Covered Lines: 2447
Relevant Lines: 3870

💛 - Coveralls

Copy link
Collaborator

@hopeyen hopeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg, thanks! 🚢

@aasseman aasseman merged commit d820f77 into main Feb 6, 2024
8 checks passed
@aasseman aasseman deleted the aasseman/fix_toolshed_deps branch February 6, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 High priority size:medium Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants