Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RAV value threshold per sender #113

Merged
merged 12 commits into from
Feb 16, 2024
Merged

Make RAV value threshold per sender #113

merged 12 commits into from
Feb 16, 2024

Conversation

aasseman
Copy link
Contributor

Fixes #93

@aasseman aasseman added size:x-large Very large p1 High priority labels Jan 31, 2024
@aasseman aasseman requested a review from gusinacio January 31, 2024 20:39
@aasseman aasseman self-assigned this Jan 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 31, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7924077728

Details

  • -209 of 822 (74.57%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.6%) to 64.632%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tap-agent/src/agent.rs 0 2 0.0%
tap-agent/src/tap/sender_accounts_manager.rs 85 152 55.92%
tap-agent/src/tap/sender_account.rs 331 399 82.96%
tap-agent/src/tap/sender_allocation.rs 196 268 73.13%
Totals Coverage Status
Change from base Build 7856562898: 1.6%
Covered Lines: 2763
Relevant Lines: 4275
💛 - Coveralls

gusinacio
gusinacio reviewed Feb 7, 2024
View reviewed changes
tap-agent/src/tap/sender_accounts_manager.rs Outdated Show resolved Hide resolved
tap-agent/src/tap/sender_accounts_manager.rs Outdated Show resolved Hide resolved
tap-agent/src/tap/sender_account.rs Outdated Show resolved Hide resolved
tap-agent/src/tap/sender_account.rs Outdated Show resolved Hide resolved
tap-agent/src/tap/sender_account.rs Outdated Show resolved Hide resolved
tap-agent/src/tap/sender_account.rs Outdated Show resolved Hide resolved
tap-agent/src/tap/sender_allocation.rs Outdated Show resolved Hide resolved
tap-agent/src/tap/sender_account.rs Outdated Show resolved Hide resolved
@aasseman aasseman requested a review from gusinacio February 9, 2024 23:10
@aasseman aasseman requested a review from gusinacio February 13, 2024 23:17
gusinacio
gusinacio reviewed Feb 13, 2024
View reviewed changes
tap-agent/src/tap/sender_account.rs Outdated Show resolved Hide resolved
tap-agent/src/tap/sender_accounts_manager.rs Outdated Show resolved Hide resolved
tap-agent/src/tap/sender_account.rs Outdated Show resolved Hide resolved
@aasseman aasseman requested a review from gusinacio February 14, 2024 00:40
gusinacio
gusinacio previously approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aasseman and others added 12 commits February 15, 2024 16:15
@aasseman
Make RAV value threshold per sender
57afc67 
Fixes #93

Signed-off-by: Alexis Asseman <[email protected]>
@aasseman
fix: simplify rav_requester_finalize error handling
9af8200 
Signed-off-by: Alexis Asseman <[email protected]>
@aasseman
fix: proper signer/sender handling at startup DB SenderAccount loading
bb3e07d 
Signed-off-by: Alexis Asseman <[email protected]>
@aasseman
test: cleanup
5c951e6 
Signed-off-by: Alexis Asseman <[email protected]>
@aasseman
fix: nested SQL query in sender_accounts_manager
0b5d597 
Signed-off-by: Alexis Asseman <[email protected]>
@aasseman
refactor: move static methods into Inner impl
f4b131e 
Signed-off-by: Alexis Asseman <[email protected]>
@aasseman
refactor: simplify SenderAcccount's fees_add
31fafa1 
Signed-off-by: Alexis Asseman <[email protected]>
@aasseman
refactor: replace active and ineligible allocations with AllocationSt…
cfcfccb 
…ateEnum and single HashMap

Signed-off-by: Alexis Asseman <[email protected]>
@gusinacio @aasseman
fix: locking issue and recompute unaggregated fees
6cfa0a6
@aasseman
fix: unaggregated fees update race condition with tokio mutex guards
6a30136 
Signed-off-by: Alexis Asseman <[email protected]>
@aasseman
chore: fix comments
6f1ec7c 
Signed-off-by: Alexis Asseman <[email protected]>
@aasseman
fix: use std mutex for sender_accounts
12bc4aa 
Signed-off-by: Alexis Asseman <[email protected]>
@aasseman
Copy link
Contributor Author

Non-trivial rebase onto main (to apply #116 and #118)

@aasseman aasseman requested a review from gusinacio February 16, 2024 00:52
gusinacio
gusinacio approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aasseman aasseman merged commit 308562e into main Feb 16, 2024
8 checks passed
@aasseman aasseman deleted the aasseman/issue93 branch February 16, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gusinacio gusinacio gusinacio approved these changes

Assignees

@aasseman aasseman

Labels
p1 High priority size:x-large Very large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make RAV value threshold per sender
2 participants
@aasseman @gusinacio