Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TAP addresses formatting in DB #116

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

aasseman
Copy link
Contributor

@aasseman aasseman commented Feb 2, 2024

Standardize around lowercase hex string (without leading '0x')

Standardize around lowercase hex string  (without leading '0x')

Signed-off-by: Alexis Asseman <[email protected]>
@aasseman aasseman added size:small Small p0 Critical priority type:bug Something isn't working labels Feb 2, 2024
@aasseman aasseman requested a review from gusinacio February 2, 2024 03:44
@aasseman aasseman self-assigned this Feb 2, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7751113119

  • -4 of 12 (66.67%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 63.23%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tap-agent/src/tap/sender_allocation_relationship.rs 0 4 0.0%
Totals Coverage Status
Change from base Build 7749184083: -0.009%
Covered Lines: 2447
Relevant Lines: 3870

💛 - Coveralls

@aasseman aasseman merged commit 7c8e6e0 into main Feb 2, 2024
8 checks passed
@aasseman aasseman deleted the aasseman/fix_address_formatting branch February 2, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p0 Critical priority size:small Small type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants