Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not inject ObjectFactory to HttpBuildCache #31775

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

asodja
Copy link
Member

@asodja asodja commented Dec 16, 2024

Partly revert change from #30778

Fixes #31705

So we don't break some external builds.
@asodja asodja requested review from a team as code owners December 16, 2024 10:57
@asodja asodja self-assigned this Dec 16, 2024
@asodja asodja added a:regression This used to work in:build-cache labels Dec 16, 2024
@asodja asodja added this to the 8.12 RC2 milestone Dec 16, 2024
@asodja
Copy link
Member Author

asodja commented Dec 16, 2024

@bot-gradle test this

@bot-gradle

This comment has been minimized.

Copy link
Member

@lptr lptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bot-gradle
Copy link
Collaborator

The following builds have passed:

@asodja asodja added this pull request to the merge queue Dec 16, 2024
@bot-gradle
Copy link
Collaborator

WARN: Based on labels, this pull request addresses notable issue but no changes to release note found.

Merged via the queue into release with commit f84683d Dec 16, 2024
16 checks passed
@asodja asodja deleted the asodja/build-cache branch December 16, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants