Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert changes to HttpBuildCache for external plugins compatibility #31705

Closed
asodja opened this issue Dec 13, 2024 · 1 comment
Closed

Revert changes to HttpBuildCache for external plugins compatibility #31705

asodja opened this issue Dec 13, 2024 · 1 comment
Assignees
@asodja
Labels
a:regression This used to work in:build-cache
Milestone
8.12 RC2

Comments

@asodja
Copy link
Member

asodja commented Dec 13, 2024

It seems this change #30778 broke some plugins, since we inject ObjectFactory to the HttpBuildCache. See this comment: #30778 (comment)

We should revert that for now.

We should also check if there are any similar changes to other public classes in this PR.
@asodja asodja added a:regression This used to work in:build-cache labels Dec 13, 2024
@asodja asodja added this to the 8.12 RC2 milestone Dec 13, 2024
@asodja asodja self-assigned this Dec 13, 2024
@gradle gradle deleted a comment Dec 14, 2024
@asodja asodja mentioned this issue Dec 16, 2024
Merged
@asodja
Copy link
Member Author

asodja commented Dec 16, 2024

Fixed with #31775

@asodja asodja closed this as completed Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asodja asodja

Labels
a:regression This used to work in:build-cache
Projects
None yet
Milestone
8.12 RC2
Development

No branches or pull requests
1 participant
@asodja