Kadai3 2 n kumaya #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nKumaya
force-pushed
the
kadai3-2-nKumaya
branch
2 times, most recently
from
166c97c to
ededca3
Compare
nKumaya
force-pushed
the
kadai3-2-nKumaya
branch
from
ededca3 to
0c6ce00
Compare
vvakame
reviewed
Sep 10, 2018
| ``` | ||
| go run main.go [ターゲットURL] | ||
| ``` | ||
| 対象URLをCPU数に応じて分割ダウンロードを行う。 |
There was a problem hiding this comment.
なぜCPU数で分割するのでしょうか？
ダウンロードはCPU依存の処理ではないため、CPU数に分割するのが妥当かどうか怪しいです。
| func NewClient(urlString string) (*Client, error) { | ||
| var err error | ||
| client := &Client{} | ||
| client.URL, err = url.Parse(urlString) |
There was a problem hiding this comment.
err の値はすぐにチェックしましょう(普通と違うことをやると、コードを読む人に普通ではないのかと思われてしまう
| ) | ||
|
|
||
| type Client struct { | ||
| URL *url.URL |
| return err | ||
| } | ||
| defer res.Body.Close() | ||
| c.ContentLength, err = strconv.Atoi(res.Header["Content-Length"][0]) |
There was a problem hiding this comment.
Content-Length って HEAD の時は絶対あるんでしたっけ？(わすれた
| return nil | ||
| } | ||
|
|
||
| func (c *Client) newRequest(ctx context.Context, index int) (*http.Request, error) { |
There was a problem hiding this comment.
他の人のコードだと Range の値を引数で持ち回りがちなんですが、このやり方のほうが僕は好きです。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README に詳細を記入してあります。
よろしくお願い致します。