Updates Are Applied To Turkish Translation #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update From Master
Update from master
Update from master
Update Turkish translation
tr/building-community.md
tr/legal.md
tr/starting-a-project.md
umutphp
changed the title
mlinksva
reviewed
Jul 19, 2020
.github/workflows/gadpp.yml
Outdated
| API_TOKEN_GITHUB: ${{ secrets.API_TOKEN_GITHUB }} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| with: | ||
| github-username: 'umutphp' |
There was a problem hiding this comment.
I suspect this file should not be added here.
There was a problem hiding this comment.
Yes, you are right. Sorry for that. I will remove it urgently.
_articles/tr/building-community.md
Outdated
| <p markdown="1" class="pquote-credit"> | ||
| — @mikeal, ["Modern açık kaynakta katılımcı tabanını büyütmek"](https://opensource.com/life/16/5/growing-contributor-base-modern-open-source) | ||
| </p> | ||
| <img class="pquote-avatar" alt="avatar" src="https://avatars.githubusercontent.com/mikeal?s=180"> |
There was a problem hiding this comment.
Also should doublecheck that spacing changes in
s don't cause rendering problems, I recall these are very sensitive. I can check this locally if you're not able to.There was a problem hiding this comment.
It is better for me if you can check on your local.
There was a problem hiding this comment.
I'm afraid the change in spacing does seem to mess up the rendering:
Could you try to revert the spacing in <aside>s to what it was, while keeping any translation changes you made?
mlinksva
reviewed
Jul 19, 2020
mlinksva
reviewed
Jul 19, 2020
_articles/tr/starting-a-project.md
Outdated
| @@ -178,28 +178,28 @@ Teknik ayrıntılara ek olarak, bir CONTRIBUTING dosyası, aşağıdakiler gibi | |||
|
|
|||
| Sıcak, arkadaşça bir ton kullanmak ve katkılar için özel önerilerde bulunmak (örneğin, dokümantasyon yazmak veya bir web sitesi yapmak gibi) yeni gelenlerin kendilerini memnun ve istekli hissetmelerini sağlama konusunda yardımcı olabilir. | |||
|
|
|||
| Örneğin, [Active Admin](https://github.com/activeadmin/activeadmin/) [katkıda bulunan rehberine](https://github.com/activeadmin/activeadmin/blob/HEAD/CONTRIBUTING.md) şu şekilde başlar: | |||
| Örneğin, [Active Admin](https://github.com/activeadmin/activeadmin/) [katkıda bulunan rehberine](https://github.com/activeadmin/activeadmin/blob/master/CONTRIBUTING.md) şu şekilde başlar: | |||
There was a problem hiding this comment.
These should be kept as HEAD, see #1704
It looks like you started this PR before then, apologies for the extra work!
kevinjm39
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.