Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llama-run : fix context size #11094

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

ericcurtin
Copy link
Collaborator

@ericcurtin ericcurtin commented Jan 5, 2025

Set n_ctx equal to n_batch in Opt class. Now context size is a more reasonable 2048.

Set `n_ctx` equal to `n_batch` in `Opt` class. Now context size is
a more reasonable 2048.

Signed-off-by: Eric Curtin <[email protected]>
@ericcurtin
Copy link
Collaborator Author

This should be an easy review @slaren @ggerganov , I noticed context size was 512, when it should be 2048 by default

@ericcurtin
Copy link
Collaborator Author

Could we merge this?

@slaren slaren changed the title Context size by default should be 2048, not 512 llama-run : fix context size Jan 6, 2025
@slaren slaren merged commit dc7cef9 into ggerganov:master Jan 6, 2025
48 checks passed
@ericcurtin ericcurtin deleted the context-size-llama-run branch January 6, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants