-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update container images to use latest #534
Conversation
Reviewer's Guide by SourceryThis pull request updates the container images used for building and running the application. The CUDA base image is updated to 12.6.3 for both builder and runtime stages. The UBI base image is updated to 9.5. The ROCm version is updated to 6.3.1. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ericcurtin - I've reviewed your changes - here's some feedback:
Overall Comments:
- The PR title 'Update container images to use latest' is misleading - the changes actually pin to specific versions (which is good practice). Consider updating the title to something like 'Update container base images to newer versions (CUDA 12.6.3, ROCm 6.3.1, UBI 9.5)'
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
I mainly wanted to get us on 9.5, but updating everything while I'm at it |
@p5 do you know if it's possible to renovate some of these things? |
Yes! It's absolutely possible to update the Containerfile base image versions :) Depending on the behaviour you want, we can even pin to a specific digest (sha), with automated updates etc. I'm moving house next week, but will be able to contribute it in 2-3 weeks - when my computer is back up and running - unless you want to give it a go? It should be quite simple:
{
...
"enabledManagers": ["dockerfile", "regex"]
}
{
...
"dockerfile": {
"fileMatch": [
"(^|/|\\.)Containerfile$",
"(^|/)Containerfile[^/]*$"
]
}
} Changing the .repo files would be quite a bit more work though, and require some custom regex. I might suggest generating these during the build itself by querying datasources on the image directly (e.g. /etc/os-release) to bypass Renovate. |
3ebc3ec
to
63b7015
Compare
@p5 happy to wait, you'd get this up and running much quicker than me, hope the move goes great! |
Update CUDA base image from version to 12.6.3 for both builder and runtime stages. Update UBI base image to 9.5. Update ROCm version in to 6.3.1. Signed-off-by: Eric Curtin <[email protected]>
@rhatdan if we haven't rebuilt the container images yet, I think it's worth getting this one in. |
Actually we should get this in before we rebuild images: context size is a measly 512, it should be 2048, a bug. |
|
||
# Final runtime image | ||
FROM docker.io/nvidia/cuda:12.6.2-runtime-ubi9 | ||
FROM docker.io/nvidia/cuda:12.6.3-runtime-ubi9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change this to pull from the google cloud mirror.
LGTM |
Update CUDA base image from version to 12.6.3 for both builder and runtime stages. Update UBI base image to 9.5. Update ROCm version in to 6.3.1.
Summary by Sourcery
Update container images. Update CUDA base image to 12.6.3 for both builder and runtime stages. Update UBI base image to 9.5. Update ROCm version to 6.3.1.
Build: