Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update container images to use latest #534

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Update container images to use latest #534

merged 1 commit into from
Jan 6, 2025

Conversation

ericcurtin
Copy link
Collaborator

@ericcurtin ericcurtin commented Jan 5, 2025

Update CUDA base image from version to 12.6.3 for both builder and runtime stages. Update UBI base image to 9.5. Update ROCm version in to 6.3.1.

Summary by Sourcery

Update container images. Update CUDA base image to 12.6.3 for both builder and runtime stages. Update UBI base image to 9.5. Update ROCm version to 6.3.1.

Build:

  • Update the CUDA base image from 12.6.2 to 12.6.3.
  • Update the UBI base image from 9.4 to 9.5.
  • Update the ROCm version from 6.2.2 to 6.3.1.

Copy link
Contributor

sourcery-ai bot commented Jan 5, 2025

Reviewer's Guide by Sourcery

This pull request updates the container images used for building and running the application. The CUDA base image is updated to 12.6.3 for both builder and runtime stages. The UBI base image is updated to 9.5. The ROCm version is updated to 6.3.1.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update CUDA base image to 12.6.3
  • Updated the CUDA base image from 12.6.2 to 12.6.3 for both the builder and runtime stages.
container-images/cuda/Containerfile
Update UBI base image to 9.5
  • Updated the UBI base image from 9.4-1214.1729773476 to 9.5.
container-images/ramalama/Containerfile
Update ROCm version to 6.3.1
  • Updated the ROCm version from 6.2.2 to 6.3.1.
  • Updated the amdgpu.repo and rocm.repo files to reflect the ROCm version change.
container-images/rocm/Containerfile
container-images/rocm/amdgpu.repo
container-images/rocm/rocm.repo

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ericcurtin - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The PR title 'Update container images to use latest' is misleading - the changes actually pin to specific versions (which is good practice). Consider updating the title to something like 'Update container base images to newer versions (CUDA 12.6.3, ROCm 6.3.1, UBI 9.5)'
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericcurtin
Copy link
Collaborator Author

I mainly wanted to get us on 9.5, but updating everything while I'm at it

@ericcurtin
Copy link
Collaborator Author

@p5 do you know if it's possible to renovate some of these things?

@p5
Copy link
Contributor

p5 commented Jan 5, 2025

@p5 do you know if it's possible to renovate some of these things?

Yes! It's absolutely possible to update the Containerfile base image versions :)

Depending on the behaviour you want, we can even pin to a specific digest (sha), with automated updates etc.

I'm moving house next week, but will be able to contribute it in 2-3 weeks - when my computer is back up and running - unless you want to give it a go?

It should be quite simple:

  1. Update the renovate.json5 file to enable the Docker manager
    Something like:
  {
      ...
      "enabledManagers": ["dockerfile", "regex"]
  }
  1. See what happens
  2. Maybe change a setting to tell Renovate to look at Containerfiles (example)
  {
      ...
      "dockerfile": {
          "fileMatch": [
              "(^|/|\\.)Containerfile$",
              "(^|/)Containerfile[^/]*$"
          ]
      }
  }

Changing the .repo files would be quite a bit more work though, and require some custom regex. I might suggest generating these during the build itself by querying datasources on the image directly (e.g. /etc/os-release) to bypass Renovate.

@ericcurtin ericcurtin force-pushed the updates branch 3 times, most recently from 3ebc3ec to 63b7015 Compare January 5, 2025 18:27
@ericcurtin
Copy link
Collaborator Author

@p5 happy to wait, you'd get this up and running much quicker than me, hope the move goes great!

Update CUDA base image from version to 12.6.3 for both builder
and runtime stages. Update UBI base image to 9.5. Update ROCm
version in to 6.3.1.

Signed-off-by: Eric Curtin <[email protected]>
@ericcurtin
Copy link
Collaborator Author

@rhatdan if we haven't rebuilt the container images yet, I think it's worth getting this one in.

@ericcurtin
Copy link
Collaborator Author

Actually we should get this in before we rebuild images:

ggerganov/llama.cpp#11094

context size is a measly 512, it should be 2048, a bug.


# Final runtime image
FROM docker.io/nvidia/cuda:12.6.2-runtime-ubi9
FROM docker.io/nvidia/cuda:12.6.3-runtime-ubi9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change this to pull from the google cloud mirror.

@rhatdan
Copy link
Member

rhatdan commented Jan 6, 2025

LGTM

@rhatdan rhatdan merged commit 6c83731 into main Jan 6, 2025
12 checks passed
@ericcurtin ericcurtin deleted the updates branch January 6, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants