Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM package: Add @geospatial-sdk/geocoding dependency #793

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Feb 7, 2024

Description

This PR ads the missing @geospatial-sdk/geocoding dependency to the npm package.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Affected libs: feature-map, feature-dataviz, feature-record, feature-router, api-metadata-converter, feature-search, api-repository, feature-catalog, feature-auth, feature-editor, ui-search, data-access-datafeeder, util-data-fetcher, data-access-gn4, util-app-config, common-fixtures, util-shared, ui-elements, ui-catalog, ui-widgets, ui-inputs, ui-map, common-domain, ui-dataviz, util-i18n, ui-layout,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer, metadata-converter, datafeeder, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 84.014% (+0.8%) from 83.173%
when pulling c65404e on npm-dep-geospatial-sdk
into 2a6e8d6 on main.

@tkohr tkohr merged commit 80d7a27 into main Feb 7, 2024
8 checks passed
@tkohr tkohr deleted the npm-dep-geospatial-sdk branch February 7, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants