-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NPM package: Add more exports and fix dependencies #792
Conversation
Affected libs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the new dependencies should be added there as well:
geonetwork-ui/package/package.json
Line 39 in 04df603
"dependencies": { |
with this PR you're just suppressing the warnings, but the dependencies are still not included in the package.
I know, this workflow is tedious! I hope we can find some time to automate that in the future.
Right, thanks, I've added them there as well. |
Hum, using the There's also already a new dep ( |
To fix the dependency, I've opened #793 Regarding the missing |
Description
This PR adds some more exports to the npm package.
04df603 also tends to resolve the following error encountered using the latest (2.2.0-dev.46643468) release:
Note: Somehow, I cannot even include the
<gn-ui-markdown-parser>
component in an external project, even though it is exported. Not sure if this is related to the dependency issue above.Quality Assurance Checklist
breaking change
labelbackport <release branch>
label