feat: adds opengraph to records #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Affected libs:
|
|
📷 Screenshots are here! |
jahow
reviewed
Nov 17, 2024
apps/datahub/src/index.html
Outdated
Comment on lines
8
to
10
| <meta property="og:title" content="Datahub" /> | ||
| <meta property="og:type" content="website" /> | ||
| <meta property="og:url" content="" /> |
There was a problem hiding this comment.
Is this really required or will the angular code be enough to create those elements?
jahow
approved these changes
Nov 19, 2024
|
|
||
| @Component({ | ||
| selector: 'gn-ui-record-meta', | ||
| template: '<>', |
There was a problem hiding this comment.
it would be great if you could make this component standalone, thanks!
There was a problem hiding this comment.
Set as standalone and removed <> as it was adding this to html page :p
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces OpenGraph protocol to datahub's records. A nice implmentation would be to have a default image and base title for og:title.
But it will add more default.toml conf. I tried here to keep it simple.
🔗⚠️ Also add external viewer button to exports to be able to use it in other apps which use gn-ui
Screenshots
Quality Assurance Checklist
This work is sponsored by MEL.