Chore: make a bunch of components standalone

[jahow]

Description

The impacted components are:

• organization-details.component.ts
• organization-header.component.ts
• header-record.component.ts
• record-apis.component.ts
• record-downloads.component.ts
• record-metadata.component.ts
• record-otherlinks.component.ts
• record-page.component.ts
• record-related-records.component.ts
• record-user-feedbacks.component.ts
• records-list.component.ts
• organisations.component.ts
• chart-view.component.ts
• figure-container.component.ts
• geo-table-view.component.ts
• table-view.component.ts
• layers-panel.component.ts
• data-view-permalink.component.ts
• data-view-share.component.ts
• view-web-component.component.ts
• data-view.component.ts
• external-viewer-button.component.ts
• map-view.component.ts
• record-meta.component.ts
• favorite-star.component.ts
• catalog-title.component.ts
• language-switcher.component.ts
• organisation-preview.component.ts
• organisations-result.component.ts
• card/api-card.component.ts
• ghost/content-ghost.component.ts
• download-item.component.ts
• downloads-list.component.ts
• error.component.ts
• image-overlay-preview.component.ts
• metadata-catalog.component.ts
• metadata-contact.component.ts
• metadata-info.component.ts
• metadata-quality-item.component.ts
• metadata-quality.component.ts
• pagination-buttons.component.ts
• pagination.component.ts
• record-api-form.component.ts
• related-record-card.component.ts
• user-feedback-item.component.ts
• copy-text-button.component.ts
• navigation-button.component.ts
• star-toggle.component.ts
• expandable-panel-button.component.ts
• expandable-panel.component.ts
• loading-mask.component.ts
• progress-bar.component.ts
• spinning-loader.component.ts

Quality Assurance Checklist

• Commit history is devoid of any merge commits and readable to facilitate reviews
• If new logic ⚙️ is introduced: unit tests were added
• If new user stories 🤏 are introduced: E2E tests were added
• If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
• If breaking changes 🪚 are introduced: add the breaking change label
• If bugs 🐞 are fixed: add the backport <release branch> label
• The documentation website 📚 has received the love it deserves

[jahow]

Note: I reverted #1042 to make the tests pass but this will have to be done separately (if we really do it)

[github-actions]

Affected libs: feature-catalog, feature-record, feature-router, feature-dataviz, feature-map, feature-search, ui-catalog, ui-dataviz, ui-search, ui-elements, feature-notifications, feature-editor, ui-inputs, ui-layout, ui-widgets,
Affected apps: datafeeder, datahub, metadata-editor, search, webcomponents, demo, map-viewer, metadata-converter,

• 🚀 Build and deploy storybook and demo on GitHub Pages
• 📦 Build and push affected docker images

[github-actions]

📷 Screenshots are here!

[coveralls]

coverage: 81.467% (-2.6%) from 84.054%
when pulling ce72548 on make-standalone-components
into e8d5d12 on main.

[tkohr]

Pfiou, tedious PR, thanks @jahow ! Took a look over the code, started the datahub, editor and storybook and could only make out some issues on the latter.

Some components like TableView, ApiCardComponent, GnUiLinkifyDirective throw an error like Unexpected "LoadingMaskComponent" found in the "declarations" array of the "StorybookComponentModule" NgModule, "LoadingMaskComponent" is marked as standalone and can't be declared in any NgModule - did you intend to import it instead (by adding it to the "imports" array)? in storybook.

FigureContainerComponent and FigureComponent have issues with the TranslateService, but not sure if that is related to this PR.

[tkohr]

Just for better understanding. How did you decide, which components to make standalone in each module and which ones to keep as is for now? Did you encounter any architectural limitations?

[jahow]

Good question, my approach was to pull on the thread and see what comes. So I'd start with a component that's not standalone and make it standalone and then see what components are affected and make them standalone in turn, etc. :)

[jahow]

thank you @tkohr , indeed many storybook entries were failing! I went through all of them and fixed them.

[tkohr]

Thanks, working fine now 🤩, just the e2e are red.