Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB-1037: Add dropdown to select feedback category #1100

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

LukasJoss
Copy link
Contributor

@LukasJoss LukasJoss commented Oct 17, 2024

Copy link

cypress bot commented Oct 17, 2024

web-mapviewer    Run #4114

Run Properties:  status check passed Passed #4114  •  git commit 4914ba2e90: Merge branch 'develop' into feat-PB-1037-report-problem-add-extra-options
Project web-mapviewer
Branch Review feat-PB-1037-report-problem-add-extra-options
Run status status check passed Passed #4114
Run duration 05m 07s
Commit git commit 4914ba2e90: Merge branch 'develop' into feat-PB-1037-report-problem-add-extra-options
Committer sami-nouidri-swisstopo
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 216
View all changes introduced in this branch ↗︎

@LukasJoss LukasJoss force-pushed the feat-PB-1037-report-problem-add-extra-options branch 8 times, most recently from 1535d03 to da2604d Compare October 24, 2024 13:41
@LukasJoss LukasJoss marked this pull request as ready for review October 24, 2024 13:50
@LukasJoss LukasJoss force-pushed the feat-PB-1037-report-problem-add-extra-options branch from da2604d to 23839ce Compare October 24, 2024 13:52
@LukasJoss LukasJoss requested review from pakb and ltkum October 24, 2024 14:00
Copy link
Contributor

@ltkum ltkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@LukasJoss LukasJoss force-pushed the feat-PB-1037-report-problem-add-extra-options branch 2 times, most recently from ed80a9a to 8d6279d Compare October 28, 2024 16:40
@LukasJoss LukasJoss requested a review from Luke252 October 29, 2024 13:39
Copy link
Contributor

@pakb pakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll wait for https://github.com/geoadmin/service-feedback/pull/29 to be merged and deplyed to PROD before merging this

@pakb pakb force-pushed the feat-PB-1037-report-problem-add-extra-options branch from 8d6279d to dd00d59 Compare November 6, 2024 07:15
@ltkum ltkum force-pushed the feat-PB-1037-report-problem-add-extra-options branch from dd00d59 to cdfb188 Compare December 3, 2024 08:13
@pakb pakb force-pushed the feat-PB-1037-report-problem-add-extra-options branch from 69ffcb7 to f9ac23d Compare December 6, 2024 08:43
to help our helpdesk team sort all the feedback they receive, it is not mandatory to select a feedback "category" when creating one. This will be added to the title of the email, in a manner that enables automatic rules to sort it out in the mailbox
@pakb pakb force-pushed the feat-PB-1037-report-problem-add-extra-options branch from f9ac23d to 622fdb7 Compare December 6, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants