Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multiple-collision test with justification #1515

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

scpeters
Copy link
Member

Targeting #1513

Modifies the auto-inertial test with multiple collisions with different densities so that the lumped center of gravity is at the link origin and derives the expected moment of inertia values.

Modifies the auto-inertial test with multiple collisions
with different densities so that the lumped center of
gravity is at the link origin and derives the expected
moment of inertia values.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from iche033 December 13, 2024 19:15
@scpeters scpeters requested a review from azeey as a code owner December 13, 2024 19:15
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (auto_inertia_mass@ca94a22). Learn more about missing BASE report.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             auto_inertia_mass    #1515   +/-   ##
====================================================
  Coverage                     ?   92.47%           
====================================================
  Files                        ?      138           
  Lines                        ?    18332           
  Branches                     ?        0           
====================================================
  Hits                         ?    16953           
  Misses                       ?     1379           
  Partials                     ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks!

@iche033 iche033 merged commit d0226c6 into auto_inertia_mass Dec 13, 2024
11 checks passed
@iche033 iche033 deleted the scpeters/auto_inertia_mass_test branch December 13, 2024 20:22
iche033 added a commit that referenced this pull request Dec 13, 2024
Signed-off-by: Ian Chen <[email protected]>

update python test

Signed-off-by: Ian Chen <[email protected]>

udate api doc for resolving auto inertia

Signed-off-by: Ian Chen <[email protected]>

Add tests for auto-inertial with explicit mass (#1514)

* link_dom test: Fix typo

Signed-off-by: Steve Peters <[email protected]>

* Test case for auto-inertials with explicit mass

Signed-off-by: Steve Peters <[email protected]>

---------

Signed-off-by: Steve Peters <[email protected]>

update doc add comments

Signed-off-by: Ian Chen <[email protected]>

add one more test with multiple collisions

Signed-off-by: Ian Chen <[email protected]>

Update mass expectation in auto-inertial tests

The mass is no longer explicitly set in these
Link tests, so replace the not-equals expectation
with an expectation of what the mass should be.

Signed-off-by: Steve Peters <[email protected]>

fix build

Signed-off-by: Ian Chen <[email protected]>

remove empty line

Signed-off-by: Ian Chen <[email protected]>

remove density warning, fix typo

Signed-off-by: Ian Chen <[email protected]>

Update multiple-collision test with justification (#1515)

Modifies the auto-inertial test with multiple collisions
with different densities so that the lumped center of
gravity is at the link origin and derives the expected
moment of inertia values.

Signed-off-by: Steve Peters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants