Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ruby script to use standalone executable #1489

Open
wants to merge 6 commits into
base: scpeters/gz_sdf_executable
Choose a base branch
from

Conversation

sauk2
Copy link

@sauk2 sauk2 commented Oct 14, 2024

🎉 New feature

Related to gazebosim/gz-tools#7

Summary

Updated the ruby script to use the standalone executable.

I also tried to resolve the issue of building the package because of the FrameSemantics class. You can check the error in ci of your branch.

I updated the CMakeLists and am not sure if the following is the right approach ...

  add_library(gz STATIC gz.cc ../FrameSemantics.cc)

Test it

Test any of the SDF commands

  gz sdf --help

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey azeey force-pushed the gz_sdf_executable branch from 2be0d2d to 615048c Compare December 7, 2024 00:12
azeey added 2 commits December 6, 2024 18:23
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

2 participants