URDF parser: use SDFormat 1.11, parse joint mimic #1333
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes #1327
Summary
Support for joint mimic constraints were added to SDFormat 1.11, and the design has intentionally similar syntax to the URDF joint mimic tags, but support for parsing URDF joint mimic tags was not included in #1166. This small fix updates the URDF parser to generate SDFormat 1.11 files and adds support for parsing the
//joint/mimic
tags from URDF into//joint/axis/mimic
tags from SDFormat.I've converted the
pendulum_rack_pinion
model from the harmonic_demo harmonic_mimic_mechanisms.sdf world file to a URDF for use in a test.Test it
bin/INTEGRATION_joint_axis_dom
gz sim -v 4 --physics-engine gz-physics-bullet-featherstone-plugin
and then from the sdformat source folder, run the following command to spawn thetest/sdf/joint_mimic_rack_pinion.urdf
file into the world:You should see the pendulum swinging and the rack moving back and forth.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.