Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parameter handling #664

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Dec 10, 2024

🦟 Bug fix

Summary

Builds on top of #663 and improves parameter handling so that <param> tags can be used in XML just like how it's used in <node> tags. Previously, the the bridge_params parameter was used and there was some custom parsing in the code. This PR uses code from launch_ros/actions/node.py so we get all the parsing for free.

So to set qos overrides, it would look like

<ros_gz_bridge 
    bridge_name="ros_gz_bridge"
    config_file="$(find-pkg-share ros_gz_sim_demos)/config/air_pressure.yaml"
    use_composition="false">
    
  <param name="qos_overrides./air_pressure.subscription.reliability" value="best_effort" />
</ros_gz_bridge>

Instead of

  <ros_gz_bridge
    bridge_name="ros_gz_bridge"
    config_file="$(find-pkg-share ros_gz_sim_demos)/config/air_pressure.yaml"
    use_composition="true"
    bridge_params="'qos_overrides./air_pressure.publisher.reliability': 'best_effort'" />

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey azeey requested a review from ahcorde as a code owner December 10, 2024 21:07
@azeey azeey requested review from caguero and ahcorde and removed request for ahcorde December 10, 2024 21:07
@ahcorde ahcorde merged commit 15465f0 into gazebosim:ros2 Dec 11, 2024
4 checks passed
@azeey azeey deleted the improve_parameter_handling branch December 11, 2024 14:14
@azeey
Copy link
Contributor Author

azeey commented Dec 11, 2024

Note that this is a breaking change relative to #628, but I think it's okay since we haven't made a release.

@ahcorde
Copy link
Collaborator

ahcorde commented Dec 11, 2024

https://github.com/Mergifyio backport jazzy

Copy link
Contributor

mergify bot commented Dec 11, 2024

backport jazzy

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants