Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set boolean params with ros_gz_bridge xml #658

Closed
wants to merge 1 commit into from

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Nov 29, 2024

🦟 Bug fix

Summary

I was not able to set

    bridge_params="'qos_overrides./air_pressure.publisher.reliability': 'best_effort', 'use_sim_time': True"/>

because the true internally is a string, this should convert the string in a bool type

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde requested a review from caguero November 29, 2024 10:05
@ahcorde ahcorde self-assigned this Nov 29, 2024
@ahcorde ahcorde mentioned this pull request Nov 29, 2024
8 tasks
@ahcorde
Copy link
Collaborator Author

ahcorde commented Dec 11, 2024

superseed by #663 and #664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant