Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use_respawn argument causing errors #651

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Fix use_respawn argument causing errors #651

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22d7fc8
Fix use_respawn argument causing errors
Amronos Nov 21, 2024
53cfb61
Merge branch 'ros2' into fix-use_respawn
Amronos Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ros_gz_bridge/ros_gz_bridge/actions/ros_gz_bridge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,9 @@ def execute(self, context: LaunchContext) -> Optional[List[Action]]:
if isinstance(self.__create_own_container, list):
self.__create_own_container = self.__create_own_container[0]

if isinstance(self.__use_respawn, list):
self.__use_respawn = self.__use_respawn[0]

# Standard node configuration
load_nodes = GroupAction(
condition=IfCondition(PythonExpression(['not ', self.__use_composition])),
Expand All @@ -185,7 +188,7 @@ def execute(self, context: LaunchContext) -> Optional[List[Action]]:
name=self.__bridge_name,
namespace=self.__namespace,
output='screen',
respawn=self.__use_respawn,
respawn=bool(self.__use_respawn),
respawn_delay=2.0,
parameters=[{'config_file': self.__config_file, **parsed_bridge_params}],
arguments=['--ros-args', '--log-level', self.__log_level],
Expand Down