Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use_respawn argument causing errors #651

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Fix use_respawn argument causing errors #651

merged 2 commits into from
Nov 21, 2024

Conversation

Amronos
Copy link
Contributor

@Amronos Amronos commented Nov 21, 2024

🦟 Bug fix

Fixes #650.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@Amronos Amronos requested a review from ahcorde as a code owner November 21, 2024 17:32
caguero
caguero approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@caguero caguero left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks for the quick fix!

@caguero caguero merged commit cfd0f8c into gazebosim:ros2 Nov 21, 2024
4 checks passed
@Amronos Amronos deleted the fix-use_respawn branch November 22, 2024 02:31
@ahcorde
Copy link
Collaborator

ahcorde commented Nov 22, 2024

@caguero do we need to backport this to jazzy ?

@caguero
Copy link
Contributor

caguero commented Nov 22, 2024

https://github.com/Mergifyio backport jazzy

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 22, 2024 •
edited
Loading

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 22, 2024
@Amronos @mergify
Fix use_respawn argument causing errors (#651)
f4be725 
Signed-off-by: Aarav Gupta <[email protected]>
(cherry picked from commit cfd0f8c)
@mergify mergify bot mentioned this pull request Nov 22, 2024
Merged
8 tasks
ahcorde added a commit that referenced this pull request Nov 22, 2024
@mergify @Amronos @ahcorde
Fix use_respawn argument causing errors (#651) (#654)
040caab 
Signed-off-by: Aarav Gupta <[email protected]>
(cherry picked from commit cfd0f8c)

Co-authored-by: Aarav Gupta <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caguero caguero caguero approved these changes

@ahcorde ahcorde Awaiting requested review from ahcorde ahcorde is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Core development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in launch file using <ros_gz_bridge>
3 participants
@Amronos @ahcorde @caguero