Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove entity node (backport #629) #647

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 21, 2024

🎉 New feature

Summary

Add remove entity node (complementary to create)

Test it

Run gz sim with any entity and call remove launch as follows:

ros2 launch ros_gz_sim gz_remove_model.launch.py world:='world_name' entity_to_remove_name:='entity_name'

Test are also provided.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸


This is an automatic backport of pull request #629 done by Mergify.

Signed-off-by: Wiktor Bajor <[email protected]>
(cherry picked from commit 04446e0)
@mergify mergify bot requested a review from ahcorde as a code owner November 21, 2024 11:53
@mergify mergify bot mentioned this pull request Nov 21, 2024
9 tasks
@ahcorde ahcorde merged commit c2c015e into jazzy Nov 21, 2024
6 checks passed
@ahcorde ahcorde deleted the mergify/bp/jazzy/pr-629 branch November 21, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants