Add remove entity node #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wiktor Bajor <[email protected]>
Signed-off-by: Wiktor Bajor <[email protected]>
caguero
reviewed
Nov 1, 2024
Signed-off-by: Wiktor Bajor <[email protected]>
ahcorde
requested changes
Nov 4, 2024
9 tasks
ahcorde
requested changes
Nov 12, 2024
Signed-off-by: Wiktor Bajor <[email protected]>
|
Done |
ahcorde
approved these changes
Nov 14, 2024
Amronos
pushed a commit
to Amronos/ros_gz
that referenced
this pull request
Nov 15, 2024
Signed-off-by: Wiktor Bajor <[email protected]> Signed-off-by: Aarav Gupta <[email protected]>
9 tasks
|
https://github.com/Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 21, 2024
Signed-off-by: Wiktor Bajor <[email protected]> (cherry picked from commit 04446e0)
9 tasks
ahcorde
pushed a commit
that referenced
this pull request
Nov 21, 2024
Signed-off-by: Wiktor Bajor <[email protected]> (cherry picked from commit 04446e0) Co-authored-by: Wiktor Bajor <[email protected]>
voshch
pushed a commit
to voshch/ros_gz
that referenced
this pull request
Dec 3, 2024
(cherry picked from commit 04446e0) # Conflicts: # ros_gz_sim/CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Add remove entity node (complementary to create)
Test it
Run gz sim with any entity and call remove launch as follows:
Test are also provided.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸