Heightmap (rendering only) #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
chapulina
added
rendering
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
iche033
reviewed
Jan 23, 2021
Codecov Report
@@ Coverage Diff @@
## main #487 +/- ##
==========================================
+ Coverage 77.34% 77.47% +0.12%
==========================================
Files 213 213
Lines 11967 12009 +42
==========================================
+ Hits 9256 9304 +48
+ Misses 2711 2705 -6
Continue to review full report at Codecov.
|
iche033
reviewed
Feb 1, 2021
Closed
chapulina
removed
the
needs upstream release
|
there are some compile errors in windows CI for other unrelated classes. Looks like it's happening in other PRs too. |
That's been fixed 🎉 (ignore the test failures 🙃 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires:
Add Heightmap class sdformat#388 (that targetssdf9, I've been using the equivalentchapulina/10/heightmapbranch to test this)Heightmap for Ogre 1 gz-rendering#180This works for me when compiling Ogre 1 from source (tag 1.9.1), but not when using debs. With debs, the heightmap only shows if the heightmap is created duringFixed onRenderUtil::Initas well as its current place. I'm still investigating.ign-rendering.This also needs to be updated as I change theDoneign-renderingimplementation so heightmap inherits from geometry.This is working now:
This is ready for review.