Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sdf plugin #1352

Merged
merged 42 commits into from
Jun 23, 2022
Merged

Use sdf plugin #1352

merged 42 commits into from
Jun 23, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Feb 19, 2022 •
edited
Loading

🎉 New feature

Summary

This PR changes Gazebo from using sdf::ElementPtr to sdf::Plugin when loading plugins. There is a lot of changes here because it's difficult to split plugin loading functionality into multiple PRs.

Use of sdf::ElementPtr will still work, and SystemPlugins still are configured using an sdf::ElementPtr. The existing tests should cover the new functionality in the PR. Under the hood, the old plugin loading functions utilize the new sdf::Plugin functions.

Here is a draft forward port of this code to Garden: #1390

Test it

Run the tests, and try to load worlds with plugins.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Nate Koenig and others added 8 commits February 10, 2022 20:59
@nkoenig nkoenig requested a review from chapulina as a code owner February 19, 2022 01:15
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Feb 19, 2022
@nkoenig nkoenig marked this pull request as draft February 19, 2022 01:15
@nkoenig nkoenig mentioned this pull request Feb 19, 2022
Merged
8 tasks
@nkoenig nkoenig changed the base branch from ign-gazebo6 to server-config-root-dom March 9, 2022 16:33
@nkoenig nkoenig marked this pull request as ready for review March 14, 2022 21:29
@nkoenig nkoenig mentioned this pull request Mar 14, 2022
Closed
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request Aug 13, 2022
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
cbec183 
Signed-off-by: Rhys Mainwaring <[email protected]>
@srmainwaring srmainwaring mentioned this pull request Aug 13, 2022
Open
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request Aug 30, 2022
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
fe95878 
Signed-off-by: Rhys Mainwaring <[email protected]>
@chapulina chapulina mentioned this pull request Aug 31, 2022
Merged
8 tasks
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request Sep 8, 2022
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
cdb494d 
Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request Sep 8, 2022
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
5078d1b 
Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request Sep 14, 2022
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
7e341f6 
Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request Nov 24, 2022
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
73e0c4f 
Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request Nov 29, 2022
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
284118e 
Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request Dec 14, 2022
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
97a8d09 
Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request Dec 21, 2022
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
1f387bd 
Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request Jan 27, 2023
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
7336dfd 
Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request Feb 2, 2023
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
51119fa 
Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request Feb 7, 2023
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
e378f63 
Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request Feb 8, 2023
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
22da9b5 
Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request Feb 15, 2023
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
3c54b1a 
Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request Feb 16, 2023
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
dfe89e7 
Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request Mar 4, 2023
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
48ebb6a 
Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request Mar 18, 2023
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
15b15ed 
Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request Mar 23, 2023
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
ab7b872 
Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request Mar 30, 2023
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
4b9600e 
Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request May 8, 2023
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
942d3c2 
Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request May 14, 2023
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
6eaff2e 
Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request May 14, 2023
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
d61bc1f 
Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request May 26, 2023
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
20793d9 
Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request May 30, 2023
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
73903d1 
Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request Jul 8, 2023
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
e251548 
Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request Sep 3, 2023
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
4aafc4b 
Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request Oct 31, 2023
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
634d5c9 
Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring added a commit to srmainwaring/gz-sim that referenced this pull request Dec 15, 2023
@srmainwaring
Partial revert gazebosim#1352 - GzSceneManager
9b351f1 
Signed-off-by: Rhys Mainwaring <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
🏯 fortress Ignition Fortress
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nkoenig @chapulina @mjcarroll @ahcorde @iche033