Remove deprecations: tock #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Agüero <[email protected]>
iche033
reviewed
Dec 5, 2024
Migration.md
Outdated
|
|
||
| ### Removals | ||
|
|
||
| * The environment variable `GZ_PHYSICS_ENGINE_INSTALL_DIR` is removed. Use |
There was a problem hiding this comment.
rephrased to say macro instead of env var
Suggested change
| * The environment variable `GZ_PHYSICS_ENGINE_INSTALL_DIR` is removed. Use | |
| * The macro `GZ_PHYSICS_ENGINE_INSTALL_DIR` is removed. Use |
CMakeLists.txt
Outdated
| @@ -97,9 +97,6 @@ message(STATUS "-------------------------------------------\n") | |||
| set(GZ_PHYSICS_ENGINE_RELATIVE_INSTALL_DIR | |||
| ${GZ_LIB_INSTALL_DIR}/gz-${GZ_DESIGNATION}-${PROJECT_VERSION_MAJOR}/engine-plugins | |||
| ) | |||
| set(GZ_PHYSICS_ENGINE_INSTALL_DIR | |||
There was a problem hiding this comment.
I think this cmake variable is still being used in different engine plugins' CMakeLists.txt for windows install. Not sure if we can remove this.
There was a problem hiding this comment.
Leave it as deprecated, then. 97f5255. Thanks!
Signed-off-by: Carlos Agüero <[email protected]>
iche033
reviewed
Dec 19, 2024
| ### Deprecations | ||
|
|
||
| * The macro `GZ_PHYSICS_ENGINE_INSTALL_DIR` is deprecated. Use | ||
| `gz::physics::getEngineInstallDir()` instead. |
There was a problem hiding this comment.
should we just remove the macro like other gz packages?
There was a problem hiding this comment.
How about now? e1e5bae
Signed-off-by: Carlos Agüero <[email protected]>
iche033
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Perform the tock of the tick-tock cycle and remove / move deprecated code.
Summary
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.