Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bullet-featherstone: Fix model frame data pose #649

Open
wants to merge 9 commits into
base: gz-physics7
Choose a base branch
from
Open

bullet-featherstone: Fix model frame data pose #649

wants to merge 9 commits into from

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jun 5, 2024

🦟 Bug fix

Related issue #648

Summary

Fix bullet-featherstone's model frame data pose.
Also expanded test to cover nested model / link / collision

More info:

I added a couple of fields in ModelInfo (modelToRootLinkTf and nestedModelFromRootModelTf) to store transforms that are computed in SDFFeatures. These transforms are then used in KinematicFeatures for computing model and nested model frame data.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested review from azeey, mxgrey and scpeters as code owners June 5, 2024 15:34
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jun 5, 2024
@iche033 iche033 mentioned this pull request Jun 5, 2024
Merged
8 tasks
@iche033 iche033 added the Bullet Bullet engine label Jun 6, 2024
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 29, 2024
@azeey azeey removed the beta Targeting beta release of upcoming collection label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeey azeey Awaiting requested review from azeey azeey is a code owner

@mxgrey mxgrey Awaiting requested review from mxgrey

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Bullet Bullet engine 🎵 harmonic Gazebo Harmonic
Projects
Core development
Status: In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iche033 @azeey