-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Quaternion pybind11 interface #324
Conversation
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-math6 #324 +/- ##
==========================================
Coverage 99.65% 99.65%
==========================================
Files 67 67
Lines 6360 6360
==========================================
Hits 6338 6338
Misses 22 22 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about getting this in, and re-enabling the matrix tests on #325?
0.707544, 0.705561, -0.0395554, 0, | ||
-0.344106, 0.392882, 0.85278, 0, | ||
0, 0, 0, 1)) | ||
# TODO(ahcorde): Enable the corresponding tests when these classes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Ouch, 🐔 and 🥚 ay... Ticketed Circular dependency between Matrix3 and Quaternion #328
Signed-off-by: Louise Poubel <[email protected]>
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
Signed-off-by: ahcorde [email protected]
🎉 New feature
Summary
This PR creates a Quaternion Pybind11 interface
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.