Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Quaternion pybind11 interface #324

Merged
merged 3 commits into from
Dec 23, 2021
Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Dec 21, 2021

Signed-off-by: ahcorde [email protected]

🎉 New feature

Summary

This PR creates a Quaternion Pybind11 interface

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde requested a review from scpeters December 21, 2021 12:46
@ahcorde ahcorde self-assigned this Dec 21, 2021
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🌱 garden Ignition Garden 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Dec 21, 2021
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #324 (fe4323b) into ign-math6 (b0f3685) will not change coverage.
The diff coverage is n/a.

❗ Current head fe4323b differs from pull request most recent head f9cab69. Consider uploading reports for the commit f9cab69 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #324   +/-   ##
==========================================
  Coverage      99.65%   99.65%           
==========================================
  Files             67       67           
  Lines           6360     6360           
==========================================
  Hits            6338     6338           
  Misses            22       22           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0f3685...f9cab69. Read the comment docs.

@chapulina chapulina added the scripting Scripting interfaces to Ignition label Dec 21, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about getting this in, and re-enabling the matrix tests on #325?

0.707544, 0.705561, -0.0395554, 0,
-0.344106, 0.392882, 0.85278, 0,
0, 0, 0, 1))
# TODO(ahcorde): Enable the corresponding tests when these classes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chapulina chapulina enabled auto-merge (squash) December 23, 2021 21:54
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina merged commit 9ab392a into ign-math6 Dec 23, 2021
@chapulina chapulina deleted the ahcorde/pybind11/quaternion branch December 23, 2021 22:56
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden Gazebo 1️1️ Dependency of Gazebo classic version 11 scripting Scripting interfaces to Ignition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants