Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump in Garden: ign-math7 and dependents #574

Closed
28 tasks done
chapulina opened this issue Nov 24, 2021 · 2 comments
Closed
28 tasks done

Bump in Garden: ign-math7 and dependents #574

chapulina opened this issue Nov 24, 2021 · 2 comments

Comments

@chapulina
Copy link
Contributor

chapulina commented Nov 24, 2021

Libraries being bumped:

ign-math7: The main motivation for a bump are are various static initialization issues being fixed on ign-math7 that can't be backported to ign-math6.

Ignition Math is low-level enough that we shouldn't do this bump lightly. One thing to keep in mind is that a lot of APIs have been updated from v6 to v7 (see gazebosim/gz-math#301), so the bump will come with lots of deprecation warnings for all downstream libraries, plugins, etc. If we'll go through the pain of handling all these deprecation warnings, I think we should consider completing the API updates for v7, so we deal with them all at once, and don't have another round of pain when v8 comes along. Having all the API consistent helps handling the deprecations more easily.

  • ign-math7

    • Source code of all downstream libraries (example)
    • Release repositories of all downstream libraries (example)
    • Use main branch on gazebodistro (example)
    • Build nightlies from the main branch (example)
    • Update gzdev to use nightlies on CI (example)
    • homebrew-simulation: create formula and update dependencies (example)
    • docs (the collection’s page) (example)
  • ign-common5: DEM support (Geospatial component for heightmap & DEMs gazebosim/gz-common#267)

    • Source code of all downstream libraries (example)
    • Release repositories of all downstream libraries (example)
    • Use main branch on gazebodistro (example)
    • Build nightlies from the main branch (example)
    • Update gzdev to use nightlies on CI (example)
    • homebrew-simulation: create formula and update dependencies (example)
    • docs (the collection’s page) (example)
  • sdformat13: Depends on ign-math

    • Source code of all downstream libraries (example)
    • Release repositories of all downstream libraries (example)
    • Use main branch on gazebodistro (example)
    • Build nightlies from the main branch (example)
    • Update gzdev to use nightlies on CI (example)
    • homebrew-simulation: create formula and update dependencies (example)
    • docs (the collection’s page) (example)
  • ign-physics6: Depends on ign-common, ign-math, sdformat

    • Source code of all downstream libraries (example)
    • Release repositories of all downstream libraries (example)
    • Use main branch on gazebodistro (example)
    • Build nightlies from the main branch (example)
    • Update gzdev to use nightlies on CI (example)
    • homebrew-simulation: create formula and update dependencies (example)
    • docs (the collection’s page) (example)

If #554 and #567 go through, bumping math shouldn't force the bump of anything that wouldn't already be bumped. #554 is in, and #567 was absorbed into this one.

Downstream libraries affected:

  • ign-fuel-tools
  • ign-gazebo
  • ign-gui
  • ign-launch
  • ign-msgs
  • ign-rendering
  • ign-sensors
  • ign-transport
@scpeters
Copy link
Contributor

@mjcarroll needs to add a dependency to ignition-math7, so I've used bump_dependency.bash to create new formulae for the relevant packages in this ticket. I ran the script for one package at a time in reverse order and only created the homebrew-simulation pull requests:

./bump_dependency.bash garden 'ign-physics' '6' 574 fortress 
./bump_dependency.bash garden 'sdformat' '13' 574 fortress 
./bump_dependency.bash garden 'ign-common' '5' 574 fortress 
./bump_dependency.bash garden 'ign-math' '7' 574 fortress 

these formulae have identical dependency information to the fortress versions, so the script will need to be run again to actually change the dependency versions

@chapulina
Copy link
Contributor Author

Running bash bump_dependency.bash garden "ign-math;ign-common;sdformat;ign-physics" "7;5;13;6" 574 fortress

This was referenced Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants