Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump in Garden: ign-msgs and dependents #554

Closed
21 tasks done
chapulina opened this issue Nov 12, 2021 · 9 comments
Closed
21 tasks done

Bump in Garden: ign-msgs and dependents #554

chapulina opened this issue Nov 12, 2021 · 9 comments

Comments

@chapulina
Copy link
Contributor

chapulina commented Nov 12, 2021

To avoid conflicts, this ticket should be worked on after #545 is closed.

Libraries being bumped:

Downstream affected libraries:

  • ign-gazebo 7
  • ign-gui 7
  • ign-launch 6
  • ign-sensors 6
@chapulina
Copy link
Contributor Author

It may be possible to keep SDF at 12 even with ign-cmake and USD

@chapulina chapulina changed the title Bump in Garden: ign-msgs, sdformat and dependents Bump in Garden: ign-msgs and dependents Nov 19, 2021
@scpeters
Copy link
Contributor

If it's not urgent, I can take a shot at #564 before this to try to simplify our bumping process

@chapulina
Copy link
Contributor Author

If it's not urgent

It's becoming more pressing for some projects, but I'd say we can wait a week or so, is that enough?

@scpeters
Copy link
Contributor

If it's not urgent

It's becoming more pressing for some projects, but I'd say we can wait a week or so, is that enough?

sure, I'll try next week and if I don't make progress we can continue the normal way

@adlarkin
Copy link

adlarkin commented Nov 22, 2021

I'm not sure who's going to work on the bumps mentioned here, but to the person who does, it would be worth using the script modifications proposed in #557 as a way to test that PR. I tested it for this issue (I didn't make any commits/PRs), and the results seemed okay - see #557 (comment) for the command I ran that would create the PRs related to this issue.

scpeters added a commit that referenced this issue Nov 23, 2021
Preparation for #554, #567.

Signed-off-by: Steve Peters <[email protected]>
scpeters added a commit that referenced this issue Nov 23, 2021
Preparation for #554, #567.

Signed-off-by: Steve Peters <[email protected]>
This was referenced Dec 3, 2021
@scpeters
Copy link
Contributor

scpeters commented Dec 8, 2021

it's done!

@scpeters scpeters closed this as completed Dec 8, 2021
@chapulina
Copy link
Contributor Author

Thanks, @scpeters !

@scpeters
Copy link
Contributor

scpeters commented Dec 8, 2021

I opened gazebo-release/gz-garden-release#3 to use symlinks in ign-garden-release as a follow-up gazebo-release/gz-garden-release#2 after noticing changes in multiple control files.

@chapulina
Copy link
Contributor Author

ign-msgs9 ... Update gzdev to use nightlies on CI

This box was checked but it hadn't been done. Noticed while working on #574. Here's the PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants