Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps in garden: use ign-math7 #285

Merged
merged 1 commit into from
Dec 29, 2021
Merged

Bumps in garden: use ign-math7 #285

merged 1 commit into from
Dec 29, 2021

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina requested a review from caguero as a code owner December 27, 2021 18:15
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Dec 27, 2021
@codecov
Copy link

codecov bot commented Dec 27, 2021 •
edited
Loading

Codecov Report

Merging #285 (522e9e6) into main (7cfc85b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #285   +/-   ##
=======================================
  Coverage   89.07%   89.07%           
=======================================
  Files          51       51           
  Lines        4769     4769           
=======================================
  Hits         4248     4248           
  Misses        521      521

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cfc85b...522e9e6. Read the comment docs.

caguero
caguero reviewed Dec 27, 2021
View reviewed changes
Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that Windows is still searching for ignition-math6.

@chapulina
Copy link
Contributor Author

It seems that Windows is still searching for ignition-math6.

That's when compiling ign-msgs, this one needs to go in first: gazebosim/gz-msgs#208

@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Dec 27, 2021
@scpeters
Copy link
Member

@osrf-jenkins run tests please

@scpeters scpeters changed the title Bumps in garden : ci_matching_branch/bump_garden_ign-transport12 Bumps in garden: use ign-math7 Dec 29, 2021
@scpeters scpeters merged commit 185961f into main Dec 29, 2021
@scpeters scpeters deleted the ci_matching_branch/bump_garden_ign-transport12 branch December 29, 2021 09:30
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caguero caguero caguero left review comments

@scpeters scpeters scpeters approved these changes

Assignees
No one assigned
Labels
🌱 garden Ignition Garden
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chapulina @scpeters @caguero