Group 1 - Petclinic refactoring WIP #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
| } | ||
| private List<String> convert_csv_to_lines(String csv) |
There was a problem hiding this comment.
I like your idea to create function convert_csv_to_lines and segment_line_to_entries :)
Try to use one consistent naming notation (e.g., camel case)
| } | ||
|
|
||
| private boolean isSamePet(Pet pet1, Pet pet2) |
There was a problem hiding this comment.
I like that you did not use more than 2 indentations (except in this method isSamePet but you would have improved this probably with more time)
| List<Pet> pets = new LinkedList<Pet>(); | ||
| Pet pet; | ||
|
|
||
| do { | ||
| pet = new Pet(); | ||
| List<String> splitCSV = segment_line_to_entries(csv); |
There was a problem hiding this comment.
you could think about extracting this content to a new method to separate the responsibilities further
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.